Re: [gentoo-portage-dev] [PATCH] repoman: Finally deprecate base.eclass

[Sergei Trofimovich <slyfox@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]

On Sun, 11 Oct 2015 09:23:20 +0200
Michał Górny <mgorny@gentoo.org> wrote:

> Contributors are repeatedly adding base.eclass uses, so we should
> finally make the deprecation formal, even at the cost of adding warnings
> for some frequently used eclasses.
> 
> Signed-off-by: Michał Górny <mgorny@gentoo.org>
> ---
>  pym/repoman/checks/ebuilds/checks.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/pym/repoman/checks/ebuilds/checks.py b/pym/repoman/checks/ebuilds/checks.py
> index ae6d96e..a00d518 100644
> --- a/pym/repoman/checks/ebuilds/checks.py
> +++ b/pym/repoman/checks/ebuilds/checks.py
> @@ -409,6 +409,7 @@ class InheritDeprecated(LineCheck):
>  
>  	# deprecated eclass : new eclass (False if no new eclass)
>  	deprecated_eclasses = {
> +		"base": False,
>  		"bash-completion": "bash-completion-r1",
>  		"boost-utils": False,
>  		"distutils": "distutils-r1",
> -- 
> 2.6.1

I would also suggest:

- adding a @DEPRECATED documentation stanza
   right into base.eclass with a migration strategy link
- and a ewarn/eqawarn call to flag all offenders and prevent
   new ebuilds to creep dependency back

-- 

  Sergei

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 181 bytes --]