public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-portage-dev] [PATCH] repoman: Set max DESCRIPTION length to 80, #562808
@ 2015-10-12  7:52 Michał Górny
  2015-10-12 15:58 ` Zac Medico
  0 siblings, 1 reply; 3+ messages in thread
From: Michał Górny @ 2015-10-12  7:52 UTC (permalink / raw
  To: gentoo-portage-dev; +Cc: Michał Górny

Correct the max DESCRIPTION length in qa_data, and remove the comment
confusingly suggesting that the variable name is taken into the count.

Bug: https://bugs.gentoo.org/show_bug.cgi?id=562808
---
 pym/repoman/qa_data.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/pym/repoman/qa_data.py b/pym/repoman/qa_data.py
index dddfb98..df9b836 100644
--- a/pym/repoman/qa_data.py
+++ b/pym/repoman/qa_data.py
@@ -7,8 +7,7 @@ from _emerge.Package import Package
 # import our initialized portage instance
 from repoman._portage import portage
 
-# 14 is the length of DESCRIPTION=""
-max_desc_len = 100
+max_desc_len = 80
 allowed_filename_chars = "a-zA-Z0-9._-+:"
 
 qahelp = {
-- 
2.6.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [gentoo-portage-dev] [PATCH] repoman: Set max DESCRIPTION length to 80, #562808
  2015-10-12  7:52 [gentoo-portage-dev] [PATCH] repoman: Set max DESCRIPTION length to 80, #562808 Michał Górny
@ 2015-10-12 15:58 ` Zac Medico
  2015-10-13 16:32   ` Michał Górny
  0 siblings, 1 reply; 3+ messages in thread
From: Zac Medico @ 2015-10-12 15:58 UTC (permalink / raw
  To: gentoo-portage-dev

On 10/12/2015 12:52 AM, Michał Górny wrote:
> Correct the max DESCRIPTION length in qa_data, and remove the comment
> confusingly suggesting that the variable name is taken into the count.
> 
> Bug: https://bugs.gentoo.org/show_bug.cgi?id=562808
> ---
>  pym/repoman/qa_data.py | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/pym/repoman/qa_data.py b/pym/repoman/qa_data.py
> index dddfb98..df9b836 100644
> --- a/pym/repoman/qa_data.py
> +++ b/pym/repoman/qa_data.py
> @@ -7,8 +7,7 @@ from _emerge.Package import Package
>  # import our initialized portage instance
>  from repoman._portage import portage
>  
> -# 14 is the length of DESCRIPTION=""
> -max_desc_len = 100
> +max_desc_len = 80
>  allowed_filename_chars = "a-zA-Z0-9._-+:"
>  
>  qahelp = {
> 

Looks good.
-- 
Thanks,
Zac


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [gentoo-portage-dev] [PATCH] repoman: Set max DESCRIPTION length to 80, #562808
  2015-10-12 15:58 ` Zac Medico
@ 2015-10-13 16:32   ` Michał Górny
  0 siblings, 0 replies; 3+ messages in thread
From: Michał Górny @ 2015-10-13 16:32 UTC (permalink / raw
  To: Zac Medico; +Cc: gentoo-portage-dev

[-- Attachment #1: Type: text/plain, Size: 1047 bytes --]

Dnia 2015-10-12, o godz. 08:58:10
Zac Medico <zmedico@gentoo.org> napisał(a):

> On 10/12/2015 12:52 AM, Michał Górny wrote:
> > Correct the max DESCRIPTION length in qa_data, and remove the comment
> > confusingly suggesting that the variable name is taken into the count.
> > 
> > Bug: https://bugs.gentoo.org/show_bug.cgi?id=562808
> > ---
> >  pym/repoman/qa_data.py | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/pym/repoman/qa_data.py b/pym/repoman/qa_data.py
> > index dddfb98..df9b836 100644
> > --- a/pym/repoman/qa_data.py
> > +++ b/pym/repoman/qa_data.py
> > @@ -7,8 +7,7 @@ from _emerge.Package import Package
> >  # import our initialized portage instance
> >  from repoman._portage import portage
> >  
> > -# 14 is the length of DESCRIPTION=""
> > -max_desc_len = 100
> > +max_desc_len = 80
> >  allowed_filename_chars = "a-zA-Z0-9._-+:"
> >  
> >  qahelp = {
> > 
> 
> Looks good.

Merged.

-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 949 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-10-13 16:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-12  7:52 [gentoo-portage-dev] [PATCH] repoman: Set max DESCRIPTION length to 80, #562808 Michał Górny
2015-10-12 15:58 ` Zac Medico
2015-10-13 16:32   ` Michał Górny

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox