public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-portage-dev] [PATCH] repoman: deprecated_classes -> ...eclasses, to ease grep
@ 2015-10-11  7:22 Michał Górny
  2015-10-11 16:15 ` Alexander Berntsen
  0 siblings, 1 reply; 3+ messages in thread
From: Michał Górny @ 2015-10-11  7:22 UTC (permalink / raw
  To: gentoo-portage-dev; +Cc: Michał Górny

Rename deprecated_classes list to deprecated_eclasses, since the latter
is less ambiguous and easier to find.

Signed-off-by: Michał Górny <mgorny@gentoo.org>
---
 pym/repoman/checks/ebuilds/checks.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pym/repoman/checks/ebuilds/checks.py b/pym/repoman/checks/ebuilds/checks.py
index 245ab2b..ae6d96e 100644
--- a/pym/repoman/checks/ebuilds/checks.py
+++ b/pym/repoman/checks/ebuilds/checks.py
@@ -408,7 +408,7 @@ class InheritDeprecated(LineCheck):
 	repoman_check_name = 'inherit.deprecated'
 
 	# deprecated eclass : new eclass (False if no new eclass)
-	deprecated_classes = {
+	deprecated_eclasses = {
 		"bash-completion": "bash-completion-r1",
 		"boost-utils": False,
 		"distutils": "distutils-r1",
@@ -436,7 +436,7 @@ class InheritDeprecated(LineCheck):
 			return
 
 		for eclass in direct_inherits:
-			replacement = self.deprecated_classes.get(eclass)
+			replacement = self.deprecated_eclasses.get(eclass)
 			if replacement is None:
 				pass
 			elif replacement is False:
-- 
2.6.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [gentoo-portage-dev] [PATCH] repoman: deprecated_classes -> ...eclasses, to ease grep
  2015-10-11  7:22 [gentoo-portage-dev] [PATCH] repoman: deprecated_classes -> ...eclasses, to ease grep Michał Górny
@ 2015-10-11 16:15 ` Alexander Berntsen
  2015-10-12 14:48   ` Michał Górny
  0 siblings, 1 reply; 3+ messages in thread
From: Alexander Berntsen @ 2015-10-11 16:15 UTC (permalink / raw
  To: gentoo-portage-dev

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Wonky commit message aside, this LGTM.

- -- 
Alexander
bernalex@gentoo.org
https://secure.plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCgAGBQJWGosXAAoJENQqWdRUGk8BgCwP/i9NdrgQQfTkcvRhamansomm
1xov9aK0+7qhIgLRSCgbuTMCTfZHo3uTbcw0cDbeSPN9PeeuFXvs/iYNo1z0YZzg
Za3kXlfDlznUNbmqK/Qze2OFINgOLsgbx3vEAHGEYy/QBjfHWrsI+lNthl5U4v81
BSTWxy56plZMck7bAuAuf+CJtM9JLBbNMvLL4gGTMJCS+Qh6ovo/DrnlhnVh7Jkd
EbCSdCx82BSV+ITNBYqYYmcDJYGROyAvupbBW8dBBuDIQkJeB7ZmZDQ6XFtfKPbs
YU+AvTEBa2pkBoENwK6IiK3ZXAcJ1dUkaFA73WLTYsTCED4WJgRW9t31tzOQtITz
7LoxdCek7Vo/x6KaBXvrTvdU78yEDc7R+WVQTPH02kLlVxjZTk7J4mQmTyNcXVtE
L4NHxBDijTvwCSDJBtMlYdOIJfeCxv8ZX9vEdPEXu6aZGpM2TEW9AtL4rVSoizlm
SK8nrPTjjosE1zeH7OD6EvCVWtWxRvr9fsdY/nW4tu5DbOeJg5cQrgJA6FUFB1Sh
ZLmGVVWrkm9mVKjMrZU8UcgPRt3GpZgxEiP7FRmi3Ofhq2lki4V1Ol9EYwTiqvp7
wWpbG0CVruvOHoen7Hr2uw5JZyii/GXcSQqIcOu9CcvvTJx1rpttYEfpQA4mstIx
344hQl5l7hL4x+T6Ap9o
=NZZt
-----END PGP SIGNATURE-----


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [gentoo-portage-dev] [PATCH] repoman: deprecated_classes -> ...eclasses, to ease grep
  2015-10-11 16:15 ` Alexander Berntsen
@ 2015-10-12 14:48   ` Michał Górny
  0 siblings, 0 replies; 3+ messages in thread
From: Michał Górny @ 2015-10-12 14:48 UTC (permalink / raw
  To: Alexander Berntsen; +Cc: gentoo-portage-dev

[-- Attachment #1: Type: text/plain, Size: 275 bytes --]

Dnia 2015-10-11, o godz. 18:15:20
Alexander Berntsen <bernalex@gentoo.org> napisał(a):

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
> 
> Wonky commit message aside, this LGTM.

Pushed.

-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 949 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-10-12 14:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-11  7:22 [gentoo-portage-dev] [PATCH] repoman: deprecated_classes -> ...eclasses, to ease grep Michał Górny
2015-10-11 16:15 ` Alexander Berntsen
2015-10-12 14:48   ` Michał Górny

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox