[gentoo-portage-dev] [PATCH] man/ebuild.5: Update description of =* operator.

[gentoo-portage-dev] [PATCH] man/ebuild.5: Update description of =* operator.

[Ulrich Müller]

After commit d4966a381ee4577818bd972946647338046715b1
"match_from_list: restrict =* to match only on version part
boundaries" the description of the =* operator in ebuild(5) was
no longer accurate.

This reverts commit 2b1eceaf79ac667eecdf1ef9585592a235c8d93f.
---
 man/ebuild.5 | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/man/ebuild.5 b/man/ebuild.5
index 6a27cc5..e60eee1 100644
--- a/man/ebuild.5
+++ b/man/ebuild.5
@@ -96,12 +96,9 @@ Example:
 .fi
 .TP
 .I *
-means match any version of the package so long
-as the specified string prefix is matched. So with a
-version of '2*', we can match '2.1', '2.2', '2.2.1',
-etc... and not match version '1.0', '3.0', '4.1', etc...
-Beware that, due to the string matching nature, '20'
-will also be matched by '2*'. The version part
+means match any version of the package so long as the specified base
+is matched.  So with a version of '2*', we can match '2.1', '2.2', '2.2.1',
+etc... and not match version '1.0', '3.0', '4.1', etc... The version part
 that comes before the '*' must be a valid version in the absence of the '*'.
 For example, '2' is a valid version and '2.' is not. Therefore, '2*' is
 allowed and '2.*' is not.
-- 
2.5.3

Re: [gentoo-portage-dev] [PATCH] man/ebuild.5: Update description of =* operator.

[Zac Medico]

On 09/22/2015 12:15 AM, Ulrich Müller wrote:
> After commit d4966a381ee4577818bd972946647338046715b1
> "match_from_list: restrict =* to match only on version part
> boundaries" the description of the =* operator in ebuild(5) was
> no longer accurate.
> 
> This reverts commit 2b1eceaf79ac667eecdf1ef9585592a235c8d93f.
> ---
>  man/ebuild.5 | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/man/ebuild.5 b/man/ebuild.5
> index 6a27cc5..e60eee1 100644
> --- a/man/ebuild.5
> +++ b/man/ebuild.5
> @@ -96,12 +96,9 @@ Example:
>  .fi
>  .TP
>  .I *
> -means match any version of the package so long
> -as the specified string prefix is matched. So with a
> -version of '2*', we can match '2.1', '2.2', '2.2.1',
> -etc... and not match version '1.0', '3.0', '4.1', etc...
> -Beware that, due to the string matching nature, '20'
> -will also be matched by '2*'. The version part
> +means match any version of the package so long as the specified base
> +is matched.  So with a version of '2*', we can match '2.1', '2.2', '2.2.1',
> +etc... and not match version '1.0', '3.0', '4.1', etc... The version part
>  that comes before the '*' must be a valid version in the absence of the '*'.
>  For example, '2' is a valid version and '2.' is not. Therefore, '2*' is
>  allowed and '2.*' is not.
> 

Looks good.
-- 
Thanks,
Zac

Re: [gentoo-portage-dev] [PATCH] man/ebuild.5: Update description of =* operator.

[Brian Dolbec]

On Tue, 22 Sep 2015 07:19:35 -0700
Zac Medico <zmedico@gentoo.org> wrote:

> On 09/22/2015 12:15 AM, Ulrich Müller wrote:
> > After commit d4966a381ee4577818bd972946647338046715b1
> > "match_from_list: restrict =* to match only on version part
> > boundaries" the description of the =* operator in ebuild(5) was
> > no longer accurate.
> > 
> > This reverts commit 2b1eceaf79ac667eecdf1ef9585592a235c8d93f.
> > ---
> >  man/ebuild.5 | 9 +++------
> >  1 file changed, 3 insertions(+), 6 deletions(-)
> > 
> > diff --git a/man/ebuild.5 b/man/ebuild.5
> > index 6a27cc5..e60eee1 100644
> > --- a/man/ebuild.5
> > +++ b/man/ebuild.5
> > @@ -96,12 +96,9 @@ Example:
> >  .fi
> >  .TP
> >  .I *
> > -means match any version of the package so long
> > -as the specified string prefix is matched. So with a
> > -version of '2*', we can match '2.1', '2.2', '2.2.1',
> > -etc... and not match version '1.0', '3.0', '4.1', etc...
> > -Beware that, due to the string matching nature, '20'
> > -will also be matched by '2*'. The version part
> > +means match any version of the package so long as the specified
> > base +is matched.  So with a version of '2*', we can match '2.1',
> > '2.2', '2.2.1', +etc... and not match version '1.0', '3.0', '4.1',
> > etc... The version part that comes before the '*' must be a valid
> > version in the absence of the '*'. For example, '2' is a valid
> > version and '2.' is not. Therefore, '2*' is allowed and '2.*' is
> > not.
> > 
> 
> Looks good.

yes, looks good other than the flak that has already started in
#gentoo-portage last night over the change...

It seems zero_chaos relied on the old behaviour, and at least one other
dev was upset over it.

almost sounded like it was going to be a pitch-forks, torches
mob was going to form ;)

But, I wonder if the change had a bug side effect...causing him the
grief
-- 
Brian Dolbec <dolsen>

Re: [gentoo-portage-dev] [PATCH] man/ebuild.5: Update description of =* operator.

[Alexander Berntsen]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 22/09/15 16:27, Brian Dolbec wrote:
> But, I wonder if the change had a bug side effect...causing him
> the grief
It appears the "problem" is that he can't exploit an old bug. So it's
actually the opposite.

- -- 
Alexander
bernalex@gentoo.org
https://secure.plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCgAGBQJWAWmRAAoJENQqWdRUGk8B2ScP/2Rt1jqOL/riWQoK7QX97Jcs
zINqtLrqK+UEEIkuHO+vxXQ2o9SmmYBVZ7HDCM2BvoZWv6vk2BnkHF0LPR3LacuM
7FDNyhOx1dpNhr3N5rXRUgtaOmnCkv5C6eK8emZRIydexZbhtetJMUZsLYMxeo95
lml1vMf62VvlPLb4bgy857MsPQse1sP5n1ZFimdGHvwvfhaWney2zdRfUPWQVLXZ
qSYny7Gwfd0NsxRZ2oOf52cc38zZ7ApAfgxC0e/hfXWSnMmca2ctBT76cD9VLL6F
yOEZ4wD8NDmziCtXK0G5+48q9DtnQ98YtWKW8P7k920b7R9BQLoGcl91mnB+JZ7x
SdU3CdoUBEIy/OqqV0cuK8XUiiTyGNOmdd63J5d6Hmt8VJEuv5YA2PI7PN9hLxCQ
x1Tqz8vble5bWdogMr0tGYHHE8A2JIDP88swML7m6CNH97SkMKWNLroWMzK34GRX
DgWicPU+7sWmmu/OzsDNi6kgJpAtvCNp97x58cbCGaGOU5pZ5rYu4aNP32aQQIIY
Vo+o/7RU2kzQ52M+AGDMWT2pjKit3ObA9GAPA+zvx4FQ2i7bYptcCe/ROji5tZh8
nBwSXxgkNIpJKi5lIJoATvMdJtw/gMx6ESkLmXnEInztwaQ+PJc43asXDX6OURQI
8FXY1Q/lOrb5zYJHIt3I
=4Ssk
-----END PGP SIGNATURE-----

Re: [gentoo-portage-dev] [PATCH] man/ebuild.5: Update description of =* operator.

[Brian Dolbec]

On Tue, 22 Sep 2015 16:45:38 +0200
Alexander Berntsen <bernalex@gentoo.org> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
> 
> On 22/09/15 16:27, Brian Dolbec wrote:
> > But, I wonder if the change had a bug side effect...causing him
> > the grief
> It appears the "problem" is that he can't exploit an old bug. So it's
> actually the opposite.
> 
> - -- 
> Alexander
> bernalex@gentoo.org
>

hey, I'm still waking up ;)  I went over the previous emails/patch.
Yeah, I see it clearly now.  He was splitting the date suffix, which
the whole date is considered as one boundary zone.
 

-- 
Brian Dolbec <dolsen>

[gentoo-portage-dev] Re: [PATCH] man/ebuild.5: Update description of =* operator.

[Duncan]

Brian Dolbec posted on Tue, 22 Sep 2015 08:09:06 -0700 as excerpted:

> On Tue, 22 Sep 2015 16:45:38 +0200 Alexander Berntsen
> <bernalex@gentoo.org> wrote:
> 
>> On 22/09/15 16:27, Brian Dolbec wrote:
>> > But, I wonder if the change had a bug side effect...causing him the
>> > grief
>> It appears the "problem" is that he can't exploit an old bug. So it's
>> actually the opposite.
>>
> hey, I'm still waking up ;)  I went over the previous emails/patch.
> Yeah, I see it clearly now.  He was splitting the date suffix, which the
> whole date is considered as one boundary zone.

Second hand as I don't do IRC (tho the date string example was 
specifically mentioned on the big dev thread a couple times, and I was as 
a result surprised to see the "bug fix" here without so much as a mention 
that if the date string thing worked it was only by accident, as it was 
always exploiting a bug...)

But as a workaround, has anyone suggested the obvious... 2015.0922 ?

I find 2015.0922 visually easier to parse than 20150922, in any case, and 
in fact routinely do break it down into four-digit substrings here, as 
extensions for dated backups of various critical config files, etc.

-- 
Duncan - List replies preferred.   No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master."  Richard Stallman

Re: [gentoo-portage-dev] Re: [PATCH] man/ebuild.5: Update description of =* operator.

[Brian Dolbec]

On Wed, 23 Sep 2015 05:04:57 +0000 (UTC)
Duncan <1i5t5.duncan@cox.net> wrote:

> Brian Dolbec posted on Tue, 22 Sep 2015 08:09:06 -0700 as excerpted:
> 
> > On Tue, 22 Sep 2015 16:45:38 +0200 Alexander Berntsen
> > <bernalex@gentoo.org> wrote:
> > 
> >> On 22/09/15 16:27, Brian Dolbec wrote:
> >> > But, I wonder if the change had a bug side effect...causing him
> >> > the grief
> >> It appears the "problem" is that he can't exploit an old bug. So
> >> it's actually the opposite.
> >>
> > hey, I'm still waking up ;)  I went over the previous emails/patch.
> > Yeah, I see it clearly now.  He was splitting the date suffix,
> > which the whole date is considered as one boundary zone.
> 
> Second hand as I don't do IRC (tho the date string example was 
> specifically mentioned on the big dev thread a couple times, and I
> was as a result surprised to see the "bug fix" here without so much
> as a mention that if the date string thing worked it was only by
> accident, as it was always exploiting a bug...)
> 
> But as a workaround, has anyone suggested the obvious... 2015.0922 ?
> 
> I find 2015.0922 visually easier to parse than 20150922, in any case,
> and in fact routinely do break it down into four-digit substrings
> here, as extensions for dated backups of various critical config
> files, etc.
> 


No, as portage developers we were too busy looking over our shoulders
watching out for the pitch-fork and torches wielding angry mob, because
we fixed a bug... ;)   which turns out only seems to have affected one
developer/user and 2 ebuilds.  But the thought did cross my mind
earlier today.  And seeing it here now, yes, I agree it does look
better and easier to read.  But as a long used form, the old/existing
method will likely be hard to to get devs to convert to the split form.
-- 
Brian Dolbec <dolsen>