From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 8050F139737 for ; Tue, 11 Aug 2015 19:53:41 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 073A0141A5; Tue, 11 Aug 2015 19:53:41 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 79780141A2 for ; Tue, 11 Aug 2015 19:53:40 +0000 (UTC) Received: from big_daddy.dol-sen.ca (S010634bdfa9ecf80.vc.shawcable.net [96.49.31.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id BE0EE340A0D for ; Tue, 11 Aug 2015 19:53:39 +0000 (UTC) Date: Tue, 11 Aug 2015 12:53:35 -0700 From: Brian Dolbec To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH] egencache: Always output EAPI=0 in cache entries Message-ID: <20150811125335.792829e4.dolsen@gentoo.org> In-Reply-To: <55CA36C2.3030008@gentoo.org> References: <1439314687-31061-1-git-send-email-mgorny@gentoo.org> <55CA36C2.3030008@gentoo.org> Organization: Gentoo Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: aa796e43-2302-43d6-9760-7ec9ffa87ec9 X-Archives-Hash: 147d8f4d43162a096b8c4cd3013f5a23 On Tue, 11 Aug 2015 10:54:10 -0700 Zac Medico wrote: > On 08/11/2015 10:38 AM, Micha=C5=82 G=C3=B3rny wrote: > > Remove the code skipping EAPI=3D0 output in cache entries. There is > > really no reason to treat EAPI=3D0 specially here, and this makes the > > output more consistent. > > --- > > bin/egencache | 2 -- > > 1 file changed, 2 deletions(-) > >=20 > > diff --git a/bin/egencache b/bin/egencache > > index 6075ccf..5c00248 100755 > > --- a/bin/egencache > > +++ b/bin/egencache > > @@ -297,8 +297,6 @@ class GenCache(object): > > # EAPI from _parse_eapi_ebuild_head, we don't > > write cache # entries for unsupported EAPIs. > > if metadata is not None and eapi_supported: > > - if metadata.get('EAPI') =3D=3D '0': > > - del metadata['EAPI'] > > for trg_cache in self._trg_caches: > > self._write_cache(trg_cache, > > cpv, repo_path, metadata, > > ebuild_hash) > >=20 >=20 > LTGM. yeah, merge please --=20 Brian Dolbec