public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Brian Dolbec <dolsen@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] [PATCH] die: call set +x since tracing only produces useless noise here
Date: Fri, 17 Jul 2015 13:48:44 -0700	[thread overview]
Message-ID: <20150717134844.3e65baac.dolsen@gentoo.org> (raw)
In-Reply-To: <1437161393-30497-1-git-send-email-zmedico@gentoo.org>

On Fri, 17 Jul 2015 12:29:53 -0700
Zac Medico <zmedico@gentoo.org> wrote:

> ---
>  bin/isolated-functions.sh | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/bin/isolated-functions.sh b/bin/isolated-functions.sh
> index 003c01d..5766921 100644
> --- a/bin/isolated-functions.sh
> +++ b/bin/isolated-functions.sh
> @@ -121,6 +121,7 @@ __helpers_die() {
>  }
>  
>  die() {
> +	set +x # tracing only produces useless noise here
>  	local IFS=$' \t\n'
>  
>  	if ___eapi_die_can_respect_nonfatal; then


Looks good
-- 
Brian Dolbec <dolsen>



      reply	other threads:[~2015-07-17 20:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-17 19:29 [gentoo-portage-dev] [PATCH] die: call set +x since tracing only produces useless noise here Zac Medico
2015-07-17 20:48 ` Brian Dolbec [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150717134844.3e65baac.dolsen@gentoo.org \
    --to=dolsen@gentoo.org \
    --cc=gentoo-portage-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox