From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 3ACDB138D0C for ; Wed, 8 Jul 2015 17:45:51 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C6021E086F; Wed, 8 Jul 2015 17:45:43 +0000 (UTC) Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 2B3AAE079E for ; Wed, 8 Jul 2015 17:45:43 +0000 (UTC) Received: by wibdq8 with SMTP id dq8so219939923wib.1 for ; Wed, 08 Jul 2015 10:45:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to; bh=6u7wu6dqvG0z/YYjWT80GvFs1sZbBACAMMPaDphB8Hk=; b=YItTcjDK2ViRq0yX4SBOMFnXMAjdALNVvpNz/R/rVSPms2+DNo8WHdwX4B3C0BMguA RVDJ5p1G71FRVcZ4H5eGSKnNsXB48yG/dsbCA0G/SOy/ymN6FGlTwh9oDKAkyavh8QZt tGvRXegdgNBT3Aht4jPvNoD69vFb+xu78FS5m6ptw0A6yeS1wLOGiUpFlHzHTJ+gxwAV xj5m1JYqy7LtPGiwLMjVRRFAFb8sfwiNpMEIIVCsdf1097jCMLwKAPTbO/0C8t8BVVed YwIzGR6Dtm7ZJGAQdloPczZlMMW41oszEGTfajJI2ACFHUIxoj4nvcunAKOMuCepF89X gNEQ== X-Received: by 10.181.11.229 with SMTP id el5mr76101038wid.40.1436377541931; Wed, 08 Jul 2015 10:45:41 -0700 (PDT) Received: from rcKGHUlyQfVFW (sbr22-2-88-185-151-243.fbx.proxad.net. [88.185.151.243]) by smtp.gmail.com with ESMTPSA id ef10sm4533245wjd.49.2015.07.08.10.45.40 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Jul 2015 10:45:41 -0700 (PDT) Date: Wed, 8 Jul 2015 19:45:31 +0200 From: =?utf-8?Q?=C3=89tienne?= Buira To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH] conf: Enable to set rsync extra opts per repository Message-ID: <20150708174531.GA29970@rcKGHUlyQfVFW> References: <20150617184030.GC26811@rcKGHUlyQfVFW> <20150617133217.303b3b68.dolsen@gentoo.org> <20150618213227.GA17153@rcKGHUlyQfVFW> <20150706112836.4e012276.dolsen@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150706112836.4e012276.dolsen@gentoo.org> X-Archives-Salt: 8b8a9e03-ae31-4954-9983-3210350a3565 X-Archives-Hash: 195ab322c5a0ac92288da7d34a5dce6d On Mon, Jul 06, 2015 at 11:28:36AM -0700, Brian Dolbec wrote: > On Thu, 18 Jun 2015 23:32:27 +0200 > Étienne Buira wrote: > > > Hi, thank you for reviewing > > > > On Wed, Jun 17, 2015 at 01:32:17PM -0700, Brian Dolbec wrote: > > > Be aware that I have not read over the diff very much yet. > > > > > > On Wed, 17 Jun 2015 20:40:30 +0200 > > > Étienne Buira wrote: > > > > > > > diff --git a/pym/portage/package/ebuild/config.py > > > > b/pym/portage/package/ebuild/config.py index 3a4007b..08db363 > > > > 100644 --- a/pym/portage/package/ebuild/config.py > > > > +++ b/pym/portage/package/ebuild/config.py > > > > @@ -515,6 +515,8 @@ class config(object): > > > > v = confs.get("SYNC") > > > > if v is not None: > > > > portdir_sync = v > > > > + if 'PORTAGE_RSYNC_EXTRA_OPTS' in > > > > confs: > > > > + > > > > self['PORTAGE_RSYNC_EXTRA_OPTS'] = > > > > confs['PORTAGE_RSYNC_EXTRA_OPTS'] self["PORTDIR"] = portdir > > > > self["PORTDIR_OVERLAY"] = portdir_overlay > > > > > > Not sure why ebuild/config.py needs changes... will look at it more > > > > For the same reason the same thing is done about ['SYNC']: forwarding > > its value to RepoConfigLoader.__init__ settings argument. > > > > > > diff --git a/pym/portage/repository/config.py > > > > b/pym/portage/repository/config.py index b7c969d..196b87a 100644 > > > > --- a/pym/portage/repository/config.py > > > > +++ b/pym/portage/repository/config.py > > > > > > > > > This approach is not wanted, it means hard coding any sync module > > > options in the main loader that might be sync-type specific. > > > > > > We want to make it generic so any arbitrary sync-type options (more > > > than the base required options) can be added for any module without > > > the need to change this. Those options are not used anywhere else > > > other than the sync module. > > > > Ok, patchset follows. > > Sorry, it's taken so long to review these ones. There has been a lot > going on recently. Hi, Thank you again for reviewing and the hints. > This is much better, I like the way you've added them for the most > part. But, you added them to the actual sync module class. By doing > that, it forces portage to load the sync module even if it is not going > to perform any sync action. Totally missed that lazy code loading point, thank you. ../.. New patchset follows. Regards.