Re: [gentoo-portage-dev] [PATCH] conf: Enable to set rsync extra opts per repository

["Étienne Buira" <etienne.buira@gmail.com>]

On Mon, Jul 06, 2015 at 11:28:36AM -0700, Brian Dolbec wrote:
> On Thu, 18 Jun 2015 23:32:27 +0200
> Étienne Buira <etienne.buira@gmail.com> wrote:
> 
> > Hi, thank you for reviewing
> > 
> > On Wed, Jun 17, 2015 at 01:32:17PM -0700, Brian Dolbec wrote:
> > > Be aware that I have not read over the diff very much yet.  
> > > 
> > > On Wed, 17 Jun 2015 20:40:30 +0200
> > > Étienne Buira <etienne.buira@gmail.com> wrote:
> > > 
> > > > diff --git a/pym/portage/package/ebuild/config.py
> > > > b/pym/portage/package/ebuild/config.py index 3a4007b..08db363
> > > > 100644 --- a/pym/portage/package/ebuild/config.py
> > > > +++ b/pym/portage/package/ebuild/config.py
> > > > @@ -515,6 +515,8 @@ class config(object):
> > > >  				v = confs.get("SYNC")
> > > >  				if v is not None:
> > > >  					portdir_sync = v
> > > > +				if 'PORTAGE_RSYNC_EXTRA_OPTS' in
> > > > confs:
> > > > +
> > > > self['PORTAGE_RSYNC_EXTRA_OPTS'] =
> > > > confs['PORTAGE_RSYNC_EXTRA_OPTS'] self["PORTDIR"] = portdir
> > > >  			self["PORTDIR_OVERLAY"] = portdir_overlay
> > > 
> > > Not sure why ebuild/config.py needs changes... will look at it more
> > 
> > For the same reason the same thing is done about ['SYNC']: forwarding
> > its value to RepoConfigLoader.__init__ settings argument.
> > 
> > > > diff --git a/pym/portage/repository/config.py
> > > > b/pym/portage/repository/config.py index b7c969d..196b87a 100644
> > > > --- a/pym/portage/repository/config.py
> > > > +++ b/pym/portage/repository/config.py
> > > 
> > > 
> > > This approach is not wanted, it means hard coding any sync module
> > > options in the main loader that might be sync-type specific.
> > > 
> > > We want to make it generic so any arbitrary sync-type options (more
> > > than the base required options) can be added for any module without
> > > the need to change this. Those options are not used anywhere else
> > > other than the sync module.
> > 
> > Ok, patchset follows.
> 
> Sorry, it's taken so long to review these ones.  There has been a lot
> going on recently.

Hi, Thank you again for reviewing and the hints.

> This is much better, I like the way you've added them for the most
> part.  But, you added them to the actual sync module class.  By doing
> that, it forces portage to load the sync module even if it is not going
> to perform any sync action.

Totally missed that lazy code loading point, thank you.

../..

New patchset follows.

Regards.