* [gentoo-portage-dev] [PATCH] unpack: avoid useless chmods to improve speed
@ 2015-07-07 9:17 Michael Haubenwallner
2015-07-07 12:12 ` Michael Haubenwallner
0 siblings, 1 reply; 3+ messages in thread
From: Michael Haubenwallner @ 2015-07-07 9:17 UTC (permalink / raw
To: gentoo-portage-dev; +Cc: Michael Haubenwallner
X-Gentoo-Bug: 554084
X-Gentoo-Bug-url: https://bugs.gentoo.org/show_bug.cgi?id=554084
---
bin/phase-helpers.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/bin/phase-helpers.sh b/bin/phase-helpers.sh
index efd2cfa..bf3ae1f 100644
--- a/bin/phase-helpers.sh
+++ b/bin/phase-helpers.sh
@@ -531,8 +531,8 @@ unpack() {
done
# Do not chmod '.' since it's probably ${WORKDIR} and PORTAGE_WORKDIR_MODE
# should be preserved.
- find . -mindepth 1 -maxdepth 1 ! -type l -print0 | \
- ${XARGS} -0 chmod -fR a+rX,u+w,g-w,o-w
+ find . -mindepth 1 '!' -type l '!' -perm /a+rX,u+w,g-w,o-w -print0 | \
+ ${XARGS} -0 chmod -f a+rX,u+w,g-w,o-w
}
econf() {
--
2.0.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [gentoo-portage-dev] [PATCH] unpack: avoid useless chmods to improve speed
2015-07-07 9:17 [gentoo-portage-dev] [PATCH] unpack: avoid useless chmods to improve speed Michael Haubenwallner
@ 2015-07-07 12:12 ` Michael Haubenwallner
2015-07-07 18:13 ` Brian Dolbec
0 siblings, 1 reply; 3+ messages in thread
From: Michael Haubenwallner @ 2015-07-07 12:12 UTC (permalink / raw
To: gentoo-portage-dev; +Cc: Michael Haubenwallner
X-Gentoo-Bug: 554084
X-Gentoo-Bug-url: https://bugs.gentoo.org/show_bug.cgi?id=554084
---
bin/phase-helpers.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/bin/phase-helpers.sh b/bin/phase-helpers.sh
index efd2cfa..b446060 100644
--- a/bin/phase-helpers.sh
+++ b/bin/phase-helpers.sh
@@ -531,8 +531,8 @@ unpack() {
done
# Do not chmod '.' since it's probably ${WORKDIR} and PORTAGE_WORKDIR_MODE
# should be preserved.
- find . -mindepth 1 -maxdepth 1 ! -type l -print0 | \
- ${XARGS} -0 chmod -fR a+rX,u+w,g-w,o-w
+ find . -mindepth 1 '!' -type l '!' -perm /a+rX,u+w,g-w,o-w \
+ -exec chmod -f a+rX,u+w,g-w,o-w '{}' +
}
econf() {
--
2.0.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [gentoo-portage-dev] [PATCH] unpack: avoid useless chmods to improve speed
2015-07-07 12:12 ` Michael Haubenwallner
@ 2015-07-07 18:13 ` Brian Dolbec
0 siblings, 0 replies; 3+ messages in thread
From: Brian Dolbec @ 2015-07-07 18:13 UTC (permalink / raw
To: gentoo-portage-dev
On Tue, 7 Jul 2015 14:12:33 +0200
Michael Haubenwallner <haubi@gentoo.org> wrote:
> X-Gentoo-Bug: 554084
> X-Gentoo-Bug-url: https://bugs.gentoo.org/show_bug.cgi?id=554084
> ---
> bin/phase-helpers.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/bin/phase-helpers.sh b/bin/phase-helpers.sh
> index efd2cfa..b446060 100644
> --- a/bin/phase-helpers.sh
> +++ b/bin/phase-helpers.sh
> @@ -531,8 +531,8 @@ unpack() {
> done
> # Do not chmod '.' since it's probably ${WORKDIR} and
> PORTAGE_WORKDIR_MODE # should be preserved.
> - find . -mindepth 1 -maxdepth 1 ! -type l -print0 | \
> - ${XARGS} -0 chmod -fR a+rX,u+w,g-w,o-w
> + find . -mindepth 1 '!' -type l '!' -perm /a+rX,u+w,g-w,o-w \
> + -exec chmod -f a+rX,u+w,g-w,o-w '{}' +
> }
>
> econf() {
Merged, Thanks
--
Brian Dolbec <dolsen>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-07 18:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-07 9:17 [gentoo-portage-dev] [PATCH] unpack: avoid useless chmods to improve speed Michael Haubenwallner
2015-07-07 12:12 ` Michael Haubenwallner
2015-07-07 18:13 ` Brian Dolbec
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox