From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id CDDBC138CED for ; Thu, 18 Jun 2015 21:32:43 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 1DF1AE07A3; Thu, 18 Jun 2015 21:32:40 +0000 (UTC) Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 79206E077A for ; Thu, 18 Jun 2015 21:32:39 +0000 (UTC) Received: by wilj4 with SMTP id j4so1910403wil.0 for ; Thu, 18 Jun 2015 14:32:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to; bh=87GUBMYMY/YpdHsQmdRqqEITscZyjqyZ08O7Kr+QxSI=; b=ih7wfHBG4WUYD91QJ8MxbBFonfcNl0iNbygA068WrlTM691h1lcN0R0gJoJsp1w3ui YHAPZ4meJBU1j5NI8HWOXDDD9VkNU4H9CctQU8tzQDXW9RbFeUaLGOMjBNyExLHxm7dO yIo/qPXmiuWg/1DjvKfkz7ilt+CI6/6z8wCVGzodlIpT8NP4M1SKe9PY2JTJVHIOt7ya c7kiF1jjeAs1LaQO6qAfuqkf2XY4EXQwhtE5WmuUs+bEFaKfo1LYp2y+Nx2fL7BYJg14 OdxZJNWeYNXaZEvmKzOcfNwYPFHIbQ65+Fgy6H3//LGUYrBUYmecxuIWl7AOXJVZef4S w92Q== X-Received: by 10.194.235.4 with SMTP id ui4mr9536693wjc.0.1434663158126; Thu, 18 Jun 2015 14:32:38 -0700 (PDT) Received: from rcKGHUlyQfVFW (sbr22-2-88-185-151-243.fbx.proxad.net. [88.185.151.243]) by mx.google.com with ESMTPSA id pf4sm13981071wjb.23.2015.06.18.14.32.36 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Jun 2015 14:32:37 -0700 (PDT) Date: Thu, 18 Jun 2015 23:32:27 +0200 From: =?utf-8?Q?=C3=89tienne?= Buira To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH] conf: Enable to set rsync extra opts per repository Message-ID: <20150618213227.GA17153@rcKGHUlyQfVFW> References: <20150617184030.GC26811@rcKGHUlyQfVFW> <20150617133217.303b3b68.dolsen@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150617133217.303b3b68.dolsen@gentoo.org> X-Archives-Salt: 311e52c6-ec18-423c-b50f-3447ace4e4c3 X-Archives-Hash: 322c3950ce81e0aa4fcbce32150654d6 Hi, thank you for reviewing On Wed, Jun 17, 2015 at 01:32:17PM -0700, Brian Dolbec wrote: > Be aware that I have not read over the diff very much yet. > > On Wed, 17 Jun 2015 20:40:30 +0200 > Étienne Buira wrote: > > > diff --git a/pym/portage/package/ebuild/config.py > > b/pym/portage/package/ebuild/config.py index 3a4007b..08db363 100644 > > --- a/pym/portage/package/ebuild/config.py > > +++ b/pym/portage/package/ebuild/config.py > > @@ -515,6 +515,8 @@ class config(object): > > v = confs.get("SYNC") > > if v is not None: > > portdir_sync = v > > + if 'PORTAGE_RSYNC_EXTRA_OPTS' in > > confs: > > + > > self['PORTAGE_RSYNC_EXTRA_OPTS'] = confs['PORTAGE_RSYNC_EXTRA_OPTS'] > > self["PORTDIR"] = portdir > > self["PORTDIR_OVERLAY"] = portdir_overlay > > Not sure why ebuild/config.py needs changes... will look at it more For the same reason the same thing is done about ['SYNC']: forwarding its value to RepoConfigLoader.__init__ settings argument. > > diff --git a/pym/portage/repository/config.py > > b/pym/portage/repository/config.py index b7c969d..196b87a 100644 > > --- a/pym/portage/repository/config.py > > +++ b/pym/portage/repository/config.py > > > This approach is not wanted, it means hard coding any sync module > options in the main loader that might be sync-type specific. > > We want to make it generic so any arbitrary sync-type options (more > than the base required options) can be added for any module without the > need to change this. Those options are not used anywhere else other > than the sync module. Ok, patchset follows. > One method might be to replace the copying of the configparser options > into python variables. Instead change it to look for the option in the > configparser instance. And only maintain some base options or > functions which pull from the config instance. Not sure i understood what you meant, nor how that would look like, please explain if patchset is not oked. Regards.