From: Mike Frysinger <vapier@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] [PATCH v4] xattr: centralize the various shims in one place
Date: Thu, 11 Jun 2015 01:39:30 -0400 [thread overview]
Message-ID: <20150611053930.GK13517@vapier> (raw)
In-Reply-To: <557887F6.1070100@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 490 bytes --]
On 10 Jun 2015 11:54, Zac Medico wrote:
> On 05/30/2015 01:59 PM, Mike Frysinger wrote:
> LGTM, except this one line is indented with spaces instead of tabs in
> vartree.py:
>
> > def tar_contents(contents, root, tar, protect=None, onProgress=None,
> > - xattr=False):
> > + xattrs=False):
i don't know if we have a standard here. sometimes it's a single tab, sometimes
it's spaces to line up. i prefer the latter as that's generally what PEP8 does.
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-06-11 5:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 21:03 [gentoo-portage-dev] [PATCH] xattr: centralize the various shims in one place Mike Frysinger
2013-10-17 0:02 ` Arfrever Frehtes Taifersar Arahesis
2013-10-17 2:51 ` Mike Frysinger
2013-10-17 2:53 ` Mike Frysinger
2013-10-17 3:42 ` Arfrever Frehtes Taifersar Arahesis
2013-10-21 3:00 ` Mike Frysinger
2013-10-22 15:59 ` Arfrever Frehtes Taifersar Arahesis
2013-10-21 3:07 ` [gentoo-portage-dev] [PATCH v2] " Mike Frysinger
2013-10-22 16:09 ` Arfrever Frehtes Taifersar Arahesis
2015-05-30 15:14 ` [gentoo-portage-dev] [PATCH v3] " Mike Frysinger
2015-05-30 19:21 ` Zac Medico
2015-05-30 19:59 ` Mike Frysinger
2015-05-30 20:26 ` Mike Frysinger
2015-05-30 20:59 ` [gentoo-portage-dev] [PATCH v4] " Mike Frysinger
2015-06-10 15:46 ` Mike Frysinger
2015-06-10 18:54 ` Zac Medico
2015-06-11 5:39 ` Mike Frysinger [this message]
2015-06-11 5:43 ` Zac Medico
2015-06-11 7:06 ` Brian Dolbec
2015-06-12 12:46 ` Alexander Berntsen
2015-09-03 17:53 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150611053930.GK13517@vapier \
--to=vapier@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox