Re: [gentoo-portage-dev] [PATCH v3] xattr: centralize the various shims in one place

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 982 bytes --]

On 30 May 2015 12:21, Zac Medico wrote:
> On 05/30/2015 08:14 AM, Mike Frysinger wrote:
> > +	@classmethod
> > +	def list(cls, item, nofollow=False, namespace=None, _names_only=True):
> > +		cmd = ['getfattr', '-d', '--absolute-names', item]
> 
> All getfattr calls need to use -m- ('-' pattern means match all) in
> order to list all attributes.

i use -m already.  here's a bit more of that function:

    def list(cls, item, nofollow=False, namespace=None, _names_only=True):
        cmd = ['getfattr', '-d', '--absolute-names', item]
        if nofollow:
            cmd += ['-h']
        cmd += ['-m', ('^%s[.]' % namespace) if namespace else '']
        proc = cls._call(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE)

so when there's no namespace specified, it ends up doing:
	getfattr -d --absolute-names /path/file -m ''

which is effectively the same thing, but i can change the '' to '-' since that's 
what the documentation suggests.
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]