From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id D1BD7138CD0 for ; Sat, 30 May 2015 18:32:07 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C35B3E08AE; Sat, 30 May 2015 18:32:01 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 2F535E08A5 for ; Sat, 30 May 2015 18:32:01 +0000 (UTC) Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id 06BC1340CCB for ; Sat, 30 May 2015 18:31:59 +0000 (UTC) Date: Sat, 30 May 2015 14:31:59 -0400 From: Mike Frysinger To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH v2] install-qa-check.d: issue warnings for 32bit ELFs not using LFS Message-ID: <20150530183159.GI2101@vapier> Mail-Followup-To: gentoo-portage-dev@lists.gentoo.org References: <1432626293-22692-1-git-send-email-vapier@gentoo.org> <1432650278-31471-1-git-send-email-vapier@gentoo.org> <5564983E.20306@gentoo.org> <20150530143534.GE2101@vapier> <5569FFFF.8030504@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="07FIeBX8hApXX6Bi" Content-Disposition: inline In-Reply-To: <5569FFFF.8030504@gentoo.org> X-Archives-Salt: 77afd626-2948-4da4-a575-f21cd962205d X-Archives-Hash: bb6c6ebaf6a37e096617c85bc5342d49 --07FIeBX8hApXX6Bi Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 30 May 2015 11:22, Zac Medico wrote: > On 05/30/2015 07:36 AM, Mike Frysinger wrote: > > On 26 May 2015 08:58, Zac Medico wrote: > >> On 05/26/2015 07:24 AM, Mike Frysinger wrote: > >>> + # Only check on 32-bit systems. Filtering by $ARCH here isn't perf= ect, but > >>> + # it should be good enough for our needs. > >>> + case ${ARCH} in > >>> + arm|mips|ppc|sh|x86) ;; > >>> + *) return ;; > >>> + esac > >> > >> Shouldn't we also enable this for 64-bit archs when multilib is enable= d? > >=20 > > yes, but i think we should start here first. getting multilib right is= kind of=20 > > a pain. this should give us enough coverage i think to get people to s= tart=20 > > filing bugs which implicitly covers multilib users. once the dust has = settled,=20 > > we can look at expanding the multilib coverage. although that would re= ally=20 > > require a python implementation, and the current install hooks logic im= plicitly=20 > > requires every file to be bash. > > > > to use your pkg-config example, it installs 32bit & 64bit ELFs into /us= r/bin. =20 > > we can't scan all 32bit ELFs because it would incorrectly flag ILP32 AB= Is like=20 > > x32 & n32. >=20 > Our compute_multilib_category function has logic that could be used to > separate and filter them: >=20 > https://gitweb.gentoo.org/proj/portage.git/tree/pym/portage/dep/soname/mu= ltilib_category.py that'd require a python implementation which hooks are somewhat limited by= =20 currently ;) -mik --07FIeBX8hApXX6Bi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVagIfAAoJEEFjO5/oN/WBItsQAOMmtSR6HtIMshupeKlKSnLt 1ilp7/ewXIox5yaUm+5SUqLQ1HcyW2V5mjOyeIz45RwjBXTyK2Pnkzu2cjQc44km MEuLYj9KdRk+RDFxvhVmgxeMAvsb9k1k7XLA89Q/OliEgj7RYm5ne6wWsOMy2uEP 4WUAKjK7LXgeG06OLiS5avAhXQ+VeWk/hsifi8CybogvDyP6wC2Nu0bTMJAfLaCG ZV5T8+OICuullAIfazickY/J4QHVgNzwxY5gr2UzL+UsR/Efu6lGlo/iO4HTSLfQ dsTKcQUFFPr40LLxnlZWs11qNnhLEMpL5mV1T5ZletUHyVvy1Qkp5+Xq0Uzq8Ipk vEXmtkpHy3ogQ56u8IuFvxEucwFY6gIMgTAXm5VhiTbyrtfiRGP57R/FHHytpkI7 thBfnsoWJBX5dpt3+nA7DuDYu/iGXYmmM+lfnI85UxkYp63dQgErJotcv6Hcgq1f pMeWXXHe4IITDOkchPDR92BFlmRonq3bujPZTtPu/YxVrfuQDyTHGpLYtulh5gMt s1UBxqlHRiEHv+p4wy15W9CTNUe3pO+BQLIozHLXzu+yN0n3y1Njrny9RvyoLVZS 9YRJ3fUnKtUJHF3E9Nrv3Za0qIYiVfUSx6K8r29CyRRs98YgLvwaA5uGuP0bgMWb ff7iPFpnLo1VPIqn/ekx =2rgA -----END PGP SIGNATURE----- --07FIeBX8hApXX6Bi--