Re: [gentoo-portage-dev] [PATCH] runtests: rewrite in python

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 2242 bytes --]

On 30 May 2015 10:18, Brian Dolbec wrote:
> On Sat, 30 May 2015 12:29:14 -0400 Mike Frysinger wrote:
> > +from __future__ import print_function
> 
> If I'm not mistaken, this is not needed for 2.7+ anymore.  It is
> still for 2.6 though.

i believe you're mistaken :)
$ python2.7 -c 'print "abc"'
abc
$ python2.7 -c 'print("abc", file=open("/dev/null", "w"))'
  File "<string>", line 1
    print("abc", file=open("/dev/null", "w"))
                     ^
SyntaxError: invalid syntax

don't be fooled by the naive case:
$ python2.7 -c 'print("abc")'
abc

that's just parens around a string and since it's a single item, it's not a 
tuple, just a string.  if you were to add more, it's more obvious:
$ python2.7 -c 'print("abc", "ddd")'
('abc', 'ddd')

> > +def get_python_executable(ver):
> > +	"""Find the right python executable for |ver|"""
> > +	if ver == 'pypy':
> > +		prog = 'pypy'
> > +	else:
> > +		prog = 'python' + ver
> > +	return os.path.join(EPREFIX, 'usr', 'bin', prog)
> 
> 
> The only thing I don't like about this is it could mean more
> maintenance changes in the future if others come along.

to be clear: this is not new code.  this is (more or less) a straight port from 
bash to python.  your feedback here applies to the bash version as well.  i'd 
like to minimize the changes when converting languages and then address 
feedback like this on top of that.

> I think making the lists have more complete naming would be better
> 
> PYTHON_SUPPORTED_VERSIONS = [
> 	'python2.7',
> 	'python3.3',
> 	'python3.4',
> ]
> 
> # The rest are just "nice to have".
> PYTHON_NICE_VERSIONS = [
> 	'pypy',
> 	'python3.5',
> 	'foo-bar-7.6',
> ]
> 
> Then all that is needed in get_python_executable() is the final path.
> No other future code changes are likely to be needed.
> Also easier to override from the environment without editing code.

this makes the command line interface a bit more annoying.  today you can do:
$ runtests --python-version '2.7 3.3'

but with this change, it'd be:
$ runtests --python-version 'python2.7 python3.3'

we could add some logic so that if the arg is composed of dots & digits, we'd 
blindly prefix it with "python".
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]