From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id D8EC7138CD0 for ; Sat, 30 May 2015 14:36:09 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id D7FB7E097A; Sat, 30 May 2015 14:36:07 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 0F1FFE0968 for ; Sat, 30 May 2015 14:36:06 +0000 (UTC) Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id E5F28340DB1 for ; Sat, 30 May 2015 14:36:05 +0000 (UTC) Date: Sat, 30 May 2015 10:36:05 -0400 From: Mike Frysinger To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH v2] install-qa-check.d: issue warnings for 32bit ELFs not using LFS Message-ID: <20150530143534.GE2101@vapier> Mail-Followup-To: gentoo-portage-dev@lists.gentoo.org References: <1432626293-22692-1-git-send-email-vapier@gentoo.org> <1432650278-31471-1-git-send-email-vapier@gentoo.org> <5564983E.20306@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tmoQ0UElFV5VgXgH" Content-Disposition: inline In-Reply-To: <5564983E.20306@gentoo.org> X-Archives-Salt: ff884537-5813-4816-a6cb-4b164344bd5f X-Archives-Hash: 900bdc4992a42625c48e2bb4a4fff40e --tmoQ0UElFV5VgXgH Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 26 May 2015 08:58, Zac Medico wrote: > On 05/26/2015 07:24 AM, Mike Frysinger wrote: > > + # Only check on 32-bit systems. Filtering by $ARCH here isn't perfec= t, but > > + # it should be good enough for our needs. > > + case ${ARCH} in > > + arm|mips|ppc|sh|x86) ;; > > + *) return ;; > > + esac >=20 > Shouldn't we also enable this for 64-bit archs when multilib is enabled? yes, but i think we should start here first. getting multilib right is kin= d of=20 a pain. this should give us enough coverage i think to get people to start= =20 filing bugs which implicitly covers multilib users. once the dust has sett= led,=20 we can look at expanding the multilib coverage. although that would really= =20 require a python implementation, and the current install hooks logic implic= itly=20 requires every file to be bash. to use your pkg-config example, it installs 32bit & 64bit ELFs into /usr/bi= n. =20 we can't scan all 32bit ELFs because it would incorrectly flag ILP32 ABIs l= ike=20 x32 & n32. ideally we'd scan the whole multilib dir, but that too runs into problems. when /usr/lib is the path for both x86 multilib and non-multilib content (l= ike=20 libexec stuff), we can't blindly scan & reject all ELFs in there. the prev= ious=20 note about ILP32 applies here too. so if we're happy with this implementation, i'll start a thread on gentoo-d= ev so=20 people aren't caught by surprise, and we can merge this for the next releas= e. -mike --tmoQ0UElFV5VgXgH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVacrUAAoJEEFjO5/oN/WBGXkP/0On1/9oGcwOJ7m4tey6qtUl 9sjyKpvbTF/bPrjW55j4XRuN1hrdNhn8W5ClH+sa3kbHL2cnyJUQBsqCahE2N3tw nOJF5OXH7Wb6CO0eUHsoWkGKn0q1xJzIKX3D5xdCtsKBWa0ZgN9HqolZdaRCB4FH pZC5DbwBH/nKrysHS4zc8eyrFIFLwJj2McOwGNSEvZvRdbEHL0mPEkGcv4JyRWcV b1cQ3E8hNoQswT0ufd2/Aqcv1Zx83N6hi2vSJtEsiKkmKEkQWYA4uZwdmqJEczQ6 iIVUzOSGm1zs1drG0EmGu9K9ZdKERefpNuUyWWhQTo7cgvDNjraf17sFW8RbDUww ryqcrPzQxQDMtGpPaF5KS1Mz6MeQtYIlrH7oDVtJFfZg8o6E0SwzsPAGM7l0n5r1 F+P8+F1Y+MuiG120cAweIUeU4LTZGHwkwCS2C7Vq4SxwTtZPcvoPAxFAZd42vS6N REOhLxmAX/5GUGqx57n4tkU1X8k9ShGClJ+uaw4NAv+GtjkoDYzILKhwFnKUn9A7 W+pm8ANPXWz8nCtN2o6j2VpULUs0Qe8BhBvEeKA7Ew+ilEStD0VgLBB+YdFyTHLN 0nwqiIp5ry8AnnfRqhUpxJvlVyRgafN+2CAmAylszPj42mevMahztO1abFJvPrJ1 bo1w/0N0OmHQIQIf2Fqc =Cfha -----END PGP SIGNATURE----- --tmoQ0UElFV5VgXgH--