Re: [gentoo-portage-dev] [PATCH v2] install-qa-check.d: issue warnings for 32bit ELFs not using LFS

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1449 bytes --]

On 26 May 2015 08:58, Zac Medico wrote:
> On 05/26/2015 07:24 AM, Mike Frysinger wrote:
> > +	# Only check on 32-bit systems.  Filtering by $ARCH here isn't perfect, but
> > +	# it should be good enough for our needs.
> > +	case ${ARCH} in
> > +	arm|mips|ppc|sh|x86) ;;
> > +	*) return ;;
> > +	esac
> 
> Shouldn't we also enable this for 64-bit archs when multilib is enabled?

yes, but i think we should start here first.  getting multilib right is kind of 
a pain.  this should give us enough coverage i think to get people to start 
filing bugs which implicitly covers multilib users.  once the dust has settled, 
we can look at expanding the multilib coverage.  although that would really 
require a python implementation, and the current install hooks logic implicitly 
requires every file to be bash.

to use your pkg-config example, it installs 32bit & 64bit ELFs into /usr/bin.  
we can't scan all 32bit ELFs because it would incorrectly flag ILP32 ABIs like 
x32 & n32.

ideally we'd scan the whole multilib dir, but that too runs into problems.
when /usr/lib is the path for both x86 multilib and non-multilib content (like 
libexec stuff), we can't blindly scan & reject all ELFs in there.  the previous 
note about ILP32 applies here too.

so if we're happy with this implementation, i'll start a thread on gentoo-dev so 
people aren't caught by surprise, and we can merge this for the next release.
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]