[gentoo-portage-dev] [PATCH] config: skip missing profiles/repo_name warning when using layout.conf:repo-name

[gentoo-portage-dev] [PATCH] config: skip missing profiles/repo_name warning when using layout.conf:repo-name

[Mike Frysinger]

From: Bertrand Simonnet <bsimonnet@chromium.org>

The repo name is considered missing if there is no explicit "repo_name"
file.  But if it's set in layout.conf via repo-name, we can skip that.
Otherwise we end up with copy & paste spew.
---
 pym/portage/repository/config.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/pym/portage/repository/config.py b/pym/portage/repository/config.py
index e44b619..7401b3a 100644
--- a/pym/portage/repository/config.py
+++ b/pym/portage/repository/config.py
@@ -252,6 +252,7 @@ class RepoConfig(object):
 				# useful when having two copies of the same repo enabled
 				# to avoid modifying profiles/repo_name in one of them
 				self.name = layout_data['repo-name']
+				self.missing_repo_name = False
 
 			for value in ('allow-missing-manifest',
 				'allow-provide-virtual', 'cache-formats',
-- 
2.4.0

Re: [gentoo-portage-dev] [PATCH] config: skip missing profiles/repo_name warning when using layout.conf:repo-name

[Brian Dolbec]

On Thu, 14 May 2015 06:50:42 -0400
Mike Frysinger <vapier@gentoo.org> wrote:

> From: Bertrand Simonnet <bsimonnet@chromium.org>
> 
> The repo name is considered missing if there is no explicit
> "repo_name" file.  But if it's set in layout.conf via repo-name, we
> can skip that. Otherwise we end up with copy & paste spew.
> ---
>  pym/portage/repository/config.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/pym/portage/repository/config.py
> b/pym/portage/repository/config.py index e44b619..7401b3a 100644
> --- a/pym/portage/repository/config.py
> +++ b/pym/portage/repository/config.py
> @@ -252,6 +252,7 @@ class RepoConfig(object):
>  				# useful when having two copies of
> the same repo enabled # to avoid modifying profiles/repo_name in one
> of them self.name = layout_data['repo-name']
> +				self.missing_repo_name = False
>  
>  			for value in ('allow-missing-manifest',
>  				'allow-provide-virtual',
> 'cache-formats',

Yeah, merge please

Wasn't there a bug for this?  If there is pleas add the bug # to the
commit message
-- 
Brian Dolbec <dolsen>

Re: [gentoo-portage-dev] [PATCH] config: skip missing profiles/repo_name warning when using layout.conf:repo-name

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 503 bytes --]

On 14 May 2015 11:43, Brian Dolbec wrote:
> On Thu, 14 May 2015 06:50:42 -0400 Mike Frysinger wrote:
> > The repo name is considered missing if there is no explicit
> > "repo_name" file.  But if it's set in layout.conf via repo-name, we
> > can skip that. Otherwise we end up with copy & paste spew.
> 
> Yeah, merge please
> 
> Wasn't there a bug for this?  If there is pleas add the bug # to the
> commit message

i'm not seeing one ... searched for "repo-name" and "repo_name" ...
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [gentoo-portage-dev] [PATCH] config: skip missing profiles/repo_name warning when using layout.conf:repo-name

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 603 bytes --]

On 14 May 2015 19:01, Mike Frysinger wrote:
> On 14 May 2015 11:43, Brian Dolbec wrote:
> > On Thu, 14 May 2015 06:50:42 -0400 Mike Frysinger wrote:
> > > The repo name is considered missing if there is no explicit
> > > "repo_name" file.  But if it's set in layout.conf via repo-name, we
> > > can skip that. Otherwise we end up with copy & paste spew.
> > 
> > Yeah, merge please
> > 
> > Wasn't there a bug for this?  If there is pleas add the bug # to the
> > commit message
> 
> i'm not seeing one ... searched for "repo-name" and "repo_name" ...

i've pushed this as-is then
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]