[gentoo-portage-dev] [PATCH] squashdelta sync: fix incorrect use of _fetch()

[gentoo-portage-dev] [PATCH] squashdelta sync: fix incorrect use of _fetch()

[Michał Górny]

Fix the use of ._fetch() method not to use the return value. Since the
code refactoring, it longer returns a boolean status. Instead, it raises
an exception if fetching fails.

Fixes: https://bugs.gentoo.org/show_bug.cgi?id=549716
---
 pym/portage/sync/modules/squashdelta/squashdelta.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/pym/portage/sync/modules/squashdelta/squashdelta.py b/pym/portage/sync/modules/squashdelta/squashdelta.py
index 6d956c6..cc303be 100644
--- a/pym/portage/sync/modules/squashdelta/squashdelta.py
+++ b/pym/portage/sync/modules/squashdelta/squashdelta.py
@@ -135,8 +135,7 @@ class SquashDeltaSync(SyncBase):
 		else:
 			delta_path = os.path.join(self.cache_location, expected_delta)
 
-			if not self._fetch(expected_delta, digests = my_digests):
-				raise SquashDeltaError()
+			self._fetch(expected_delta, digests = my_digests)
 			if not self.has_bin:
 				raise SquashDeltaError()
 
-- 
2.4.0

Re: [gentoo-portage-dev] [PATCH] squashdelta sync: fix incorrect use of _fetch()

[Brian Dolbec]

On Sun, 17 May 2015 19:28:03 +0200
Michał Górny <mgorny@gentoo.org> wrote:

> Fix the use of ._fetch() method not to use the return value. Since the
> code refactoring, it longer returns a boolean status. Instead, it
> raises an exception if fetching fails.
> 
> Fixes: https://bugs.gentoo.org/show_bug.cgi?id=549716
> ---

Michał due the the alpha state of this module and continued
interpersonal and somewhat "toxic" behaviour from you (see comment #2
in that bug you reference above). We (Zac, Alexander and myself) have
decided to remove this module from portage at this time. We feel it is
best that you develop it as an independent installable portage module.
This will allow you to develop and release it as you see fit.

When the code matures we will consider including it as part of the main
portage package provided the code meets the teams QA standards.


Also, as an independent package, you could make a pkgcore sync module
for it as well and add IUSE flags for each package manager.

-- 
Brian Dolbec <dolsen>
Portage, Layman, Gentoo-keys Lead developer