From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id C6F57138CCC for ; Mon, 4 May 2015 06:48:52 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id A59BCE0818; Mon, 4 May 2015 06:48:51 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 2884AE07E6 for ; Mon, 4 May 2015 06:48:51 +0000 (UTC) Received: from big_daddy.dol-sen.ca (S010634bdfa9ecf80.vc.shawcable.net [96.49.31.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id 15013340A3C for ; Mon, 4 May 2015 06:48:50 +0000 (UTC) Date: Sun, 3 May 2015 23:48:47 -0700 From: Brian Dolbec To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH] bintree.populate: binhost connection failure triggers TypeError (bug 532784) Message-ID: <20150503234847.712df520.dolsen@gentoo.org> In-Reply-To: <554713C0.7070505@gentoo.org> References: <1430715153-27893-1-git-send-email-zmedico@gentoo.org> <20150503232503.54706511.dolsen@gentoo.org> <554713C0.7070505@gentoo.org> Organization: Gentoo Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: b5097f69-7150-4da3-aa92-16e56b34996d X-Archives-Hash: dc3ab01031b6a10c16e17f336e91b11b On Sun, 03 May 2015 23:37:52 -0700 Zac Medico wrote: > On 05/03/2015 11:25 PM, Brian Dolbec wrote: > > Isn't this backwards from what was reported. It generated a > > UnicodeDecodeError when using additional args to unicode(). > > It was actually a TypeError. > > > It needed > > to convert it to string so errors= needed to not be passed in. > > Yeah, the first unicode call fixes that. > > If a UnicodeDecodeError is then raised (not a TypeError), the second > unicode call decodes the UnicodeError.object attribute, which is > guaranteed to be a string that can be passed to unicode using the > three argument form. OK then :) -- Brian Dolbec