[gentoo-portage-dev] [PATCH] dblink: elog failed postinst (bug 547778)

[gentoo-portage-dev] [PATCH] dblink: elog failed postinst (bug 547778)

[Zac Medico]

This ensures that there's still an eerror elog message, even if the
failed postinst did not call eerror itself.

X-Gentoo-Bug: 547778
X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=547778
---
 pym/portage/dbapi/vartree.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/pym/portage/dbapi/vartree.py b/pym/portage/dbapi/vartree.py
index cacbf96..fca84d1 100644
--- a/pym/portage/dbapi/vartree.py
+++ b/pym/portage/dbapi/vartree.py
@@ -4376,8 +4376,9 @@ class dblink(object):
 		if a != os.EX_OK:
 			# It's stupid to bail out here, so keep going regardless of
 			# phase return code.
-			showMessage(_("!!! FAILED postinst: ")+str(a)+"\n",
-				level=logging.ERROR, noiselevel=-1)
+			self._elog("eerror", "postinst", [
+				_("FAILED postinst: %s") % (a,),
+			])
 
 		#update environment settings, library paths. DO NOT change symlinks.
 		env_update(
-- 
2.3.5

Re: [gentoo-portage-dev] [PATCH] dblink: elog failed postinst (bug 547778)

[Brian Dolbec]

On Sat,  2 May 2015 12:28:00 -0700
Zac Medico <zmedico@gentoo.org> wrote:

> This ensures that there's still an eerror elog message, even if the
> failed postinst did not call eerror itself.
> 
> X-Gentoo-Bug: 547778
> X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=547778
> ---
>  pym/portage/dbapi/vartree.py | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/pym/portage/dbapi/vartree.py
> b/pym/portage/dbapi/vartree.py index cacbf96..fca84d1 100644
> --- a/pym/portage/dbapi/vartree.py
> +++ b/pym/portage/dbapi/vartree.py
> @@ -4376,8 +4376,9 @@ class dblink(object):
>  		if a != os.EX_OK:
>  			# It's stupid to bail out here, so keep
> going regardless of # phase return code.
> -			showMessage(_("!!! FAILED postinst:
> ")+str(a)+"\n",
> -				level=logging.ERROR, noiselevel=-1)
> +			self._elog("eerror", "postinst", [
> +				_("FAILED postinst: %s") % (a,),
> +			])
>  
>  		#update environment settings, library paths. DO NOT
> change symlinks. env_update(


looks fine :)
-- 
Brian Dolbec <dolsen>