public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-portage-dev] [PATCH] WorldSelectedSet: fix load method for bug 542732
@ 2015-03-09 19:32 Zac Medico
  2015-03-09 19:49 ` Brian Dolbec
  0 siblings, 1 reply; 2+ messages in thread
From: Zac Medico @ 2015-03-09 19:32 UTC (permalink / raw
  To: gentoo-portage-dev; +Cc: Zac Medico

Since commit c3586c5e15c8373d08f9192713a2b03d4542faaf, the WorldSelectedSet
load method does not force the set to load if it has already been loaded.
Fix it to do so.

Fixes: c3586c5e15c8 ("WorldSelectedSet: fix breakage for bug #539746")
X-Gentoo-Bug: 542732
X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=542732
---
 pym/portage/_sets/files.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/pym/portage/_sets/files.py b/pym/portage/_sets/files.py
index 26ee094..e045701 100644
--- a/pym/portage/_sets/files.py
+++ b/pym/portage/_sets/files.py
@@ -221,7 +221,10 @@ class WorldSelectedSet(EditablePackageSet):
 		self._setset.write()
 
 	def load(self):
-		# Iterating over these sets loads them automatically.
+		# Iterating over these sets does not force them to load if they
+		# have been loaded previously.
+		self._pkgset.load()
+		self._setset.load()
 		self._setAtoms(chain(self._pkgset, self._setset))
 
 	def lock(self):
-- 
2.3.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [gentoo-portage-dev] [PATCH] WorldSelectedSet: fix load method for bug 542732
  2015-03-09 19:32 [gentoo-portage-dev] [PATCH] WorldSelectedSet: fix load method for bug 542732 Zac Medico
@ 2015-03-09 19:49 ` Brian Dolbec
  0 siblings, 0 replies; 2+ messages in thread
From: Brian Dolbec @ 2015-03-09 19:49 UTC (permalink / raw
  To: gentoo-portage-dev

On Mon,  9 Mar 2015 12:32:02 -0700
Zac Medico <zmedico@gentoo.org> wrote:

> Since commit c3586c5e15c8373d08f9192713a2b03d4542faaf, the
> WorldSelectedSet load method does not force the set to load if it has
> already been loaded. Fix it to do so.
> 
> Fixes: c3586c5e15c8 ("WorldSelectedSet: fix breakage for bug #539746")
> X-Gentoo-Bug: 542732
> X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=542732
> ---
>  pym/portage/_sets/files.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/pym/portage/_sets/files.py b/pym/portage/_sets/files.py
> index 26ee094..e045701 100644
> --- a/pym/portage/_sets/files.py
> +++ b/pym/portage/_sets/files.py
> @@ -221,7 +221,10 @@ class WorldSelectedSet(EditablePackageSet):
>  		self._setset.write()
>  
>  	def load(self):
> -		# Iterating over these sets loads them automatically.
> +		# Iterating over these sets does not force them to
> load if they
> +		# have been loaded previously.
> +		self._pkgset.load()
> +		self._setset.load()
>  		self._setAtoms(chain(self._pkgset, self._setset))
>  
>  	def lock(self):


LGTM, don't know if it fixes it, but you are the expert there ;)
-- 
Brian Dolbec <dolsen>



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-03-09 19:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-09 19:32 [gentoo-portage-dev] [PATCH] WorldSelectedSet: fix load method for bug 542732 Zac Medico
2015-03-09 19:49 ` Brian Dolbec

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox