Re: [gentoo-portage-dev] [PATCH 2/2] Add profile-formats=build-id (bug 150031)

[Brian Dolbec <dolsen@gentoo.org>]

On Tue, 17 Feb 2015 00:37:13 -0800
Zac Medico <zmedico@gentoo.org> wrote:

> When "profile-formats = build-id" is enabled in layout.conf of the
> containing repository, a dependency atom in the profile can refer
> to a specific build, using the build-id that is assigned when
> FEATURES=binpkg-multi-instance is enabled. A build-id atom is
> identical to a version-specific atom, except that the version is
> followed by a hyphen and an integer build-id.
> 
> With the build-id profile format, it is possible to assemble a system
> using specific builds of binary packages, as users of "binary"
> distros might be accustomed to. For example, an atom in the "packages"
> file can pull a specific build of a package into the @system set, and
> an atom in the "package.keywords" file can be used to modify the
> effective KEYWORDS of a specific build of a package.
> 
> Refering to specific builds can be useful for a number of reasons. For
> example, if a particular build needs to undergo a large amount of
> testing in a complex environment in order to verify reliability, then
> it can be useful to lock a profile to a specific build that has been
> thoroughly tested.
> 
> X-Gentoo-Bug: 150031
> X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=150031
> ---
>  man/portage.5                                      |   8 +-
>  pym/_emerge/is_valid_package_atom.py               |   5 +-
>  pym/portage/_sets/ProfilePackageSet.py             |   3 +-
>  pym/portage/_sets/profiles.py                      |   3 +-
>  pym/portage/dep/__init__.py                        |  35 +++++-
>  .../package/ebuild/_config/KeywordsManager.py      |   3 +-
>  .../package/ebuild/_config/LocationsManager.py     |   8 +-
>  pym/portage/package/ebuild/_config/MaskManager.py  |  21 +++-
>  pym/portage/package/ebuild/_config/UseManager.py   |  14 ++-
>  pym/portage/package/ebuild/config.py               |  15 ++-
>  pym/portage/repository/config.py                   |   2 +-
>  pym/portage/tests/dep/test_isvalidatom.py          |   8 +-
>  .../test_build_id_profile_format.py                | 134
> +++++++++++++++++++++
> pym/portage/util/__init__.py                       |  13 +- 14 files
> changed, 234 insertions(+), 38 deletions(-) create mode 100644
> pym/portage/tests/resolver/binpkg_multi_instance/test_build_id_profile_format.py
> 


class Atom()

 			if allow_repo is None:
 				allow_repo = True
+			if allow_build_id is None:
+				allow_build_id = True


these can be written as
  allow_repo = allow_repo or True
  allow_build_id = allow_build_id or True


Otherwise looks decent.

-- 
Brian Dolbec <dolsen>