public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-portage-dev] [PATCH] sync: support sync-clone-depth for DVCS-es (git --depth)
@ 2015-01-17 11:58 Michał Górny
  2015-01-17 22:04 ` Zac Medico
  2015-01-18  9:41 ` Brian Dolbec
  0 siblings, 2 replies; 7+ messages in thread
From: Michał Górny @ 2015-01-17 11:58 UTC (permalink / raw
  To: gentoo-portage-dev; +Cc: Michał Górny

Support sync-clone-depth with the default set to 1. This allows the user
to reduce the number of historical commits fetched along with the
repository (git --depth).
---
 man/portage.5                       |  4 ++++
 pym/portage/repository/config.py    | 19 ++++++++++++++++++-
 pym/portage/sync/modules/git/git.py |  6 +++++-
 3 files changed, 27 insertions(+), 2 deletions(-)

diff --git a/man/portage.5 b/man/portage.5
index f0b0e20..3fb511c 100644
--- a/man/portage.5
+++ b/man/portage.5
@@ -903,6 +903,10 @@ since operations performed by these tools are inherently
 .B priority
 Specifies priority of given repository.
 .TP
+.B sync\-clone\-depth
+Specifies clone depth to use for DVCS repositories. Defaults to 1 (only
+the newest commit). If set to 0, the depth is unlimited.
+.TP
 .B sync\-cvs\-repo
 Specifies CVS repository.
 .TP
diff --git a/pym/portage/repository/config.py b/pym/portage/repository/config.py
index 7e17e02..2c4ce8a 100644
--- a/pym/portage/repository/config.py
+++ b/pym/portage/repository/config.py
@@ -88,7 +88,8 @@ class RepoConfig(object):
 		'profile_formats', 'sign_commit', 'sign_manifest', 'sync_cvs_repo',
 		'sync_type', 'sync_umask', 'sync_uri', 'sync_user', 'thin_manifest',
 		'update_changelog', 'user_location', '_eapis_banned',
-		'_eapis_deprecated', '_masters_orig')
+		'_eapis_deprecated', '_masters_orig',
+		'sync_clone_depth')
 
 	def __init__(self, name, repo_opts, local_config=True):
 		"""Build a RepoConfig with options in repo_opts
@@ -176,6 +177,21 @@ class RepoConfig(object):
 			auto_sync = auto_sync.strip().lower()
 		self.auto_sync = auto_sync
 
+		sync_clone_depth = None
+		if self.sync_type in ('git',):
+			sync_clone_depth = repo_opts.get('sync-clone-depth')
+			if sync_clone_depth is not None:
+				try:
+					sync_clone_depth = int(sync_clone_depth)
+				except ValueError:
+					sync_clone_depth = None
+				else:
+					if sync_clone_depth == 0:
+						sync_clone_depth = None
+			else:
+				sync_clone_depth = 1
+		self.sync_clone_depth = sync_clone_depth
+
 		# Not implemented.
 		format = repo_opts.get('format')
 		if format is not None:
@@ -489,6 +505,7 @@ class RepoConfigLoader(object):
 						for k in ('aliases', 'auto_sync', 'eclass_overrides',
 							'force', 'masters', 'priority', 'sync_cvs_repo',
 							'sync_type', 'sync_umask', 'sync_uri', 'sync_user',
+							'sync_clone_depth',
 							):
 							v = getattr(repos_conf_opts, k, None)
 							if v is not None:
diff --git a/pym/portage/sync/modules/git/git.py b/pym/portage/sync/modules/git/git.py
index 35943dd..b97d501 100644
--- a/pym/portage/sync/modules/git/git.py
+++ b/pym/portage/sync/modules/git/git.py
@@ -63,9 +63,13 @@ class GitSync(SyncBase):
 		sync_uri = self.repo.sync_uri
 		if sync_uri.startswith("file://"):
 			sync_uri = sync_uri[6:]
-		exitcode = portage.process.spawn_bash("cd %s ; %s clone %s ." % \
+		depth_arg = ''
+		if self.repo.sync_clone_depth is not None:
+			depth_arg = '--depth %d ' % self.repo.sync_clone_depth
+		exitcode = portage.process.spawn_bash("cd %s ; %s clone %s%s ." % \
 			(portage._shell_quote(self.repo.location),
 			self.bin_command,
+			depth_arg,
 			portage._shell_quote(sync_uri)),
 			**portage._native_kwargs(self.spawn_kwargs))
 		if exitcode != os.EX_OK:
-- 
2.2.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [gentoo-portage-dev] [PATCH] sync: support sync-clone-depth for DVCS-es (git --depth)
  2015-01-17 11:58 [gentoo-portage-dev] [PATCH] sync: support sync-clone-depth for DVCS-es (git --depth) Michał Górny
@ 2015-01-17 22:04 ` Zac Medico
  2015-01-18  9:41 ` Brian Dolbec
  1 sibling, 0 replies; 7+ messages in thread
From: Zac Medico @ 2015-01-17 22:04 UTC (permalink / raw
  To: gentoo-portage-dev; +Cc: Michał Górny

On 01/17/2015 03:58 AM, Michał Górny wrote:
> Support sync-clone-depth with the default set to 1. This allows the user
> to reduce the number of historical commits fetched along with the
> repository (git --depth).
> ---
>  man/portage.5                       |  4 ++++
>  pym/portage/repository/config.py    | 19 ++++++++++++++++++-
>  pym/portage/sync/modules/git/git.py |  6 +++++-
>  3 files changed, 27 insertions(+), 2 deletions(-)

LGTM.
-- 
Thanks,
Zac


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [gentoo-portage-dev] [PATCH] sync: support sync-clone-depth for DVCS-es (git --depth)
  2015-01-17 11:58 [gentoo-portage-dev] [PATCH] sync: support sync-clone-depth for DVCS-es (git --depth) Michał Górny
  2015-01-17 22:04 ` Zac Medico
@ 2015-01-18  9:41 ` Brian Dolbec
  2015-01-18 10:33   ` [gentoo-portage-dev] [PATCH v2] sync: support sync-depth " Michał Górny
  1 sibling, 1 reply; 7+ messages in thread
From: Brian Dolbec @ 2015-01-18  9:41 UTC (permalink / raw
  To: gentoo-portage-dev

On Sat, 17 Jan 2015 12:58:19 +0100
Michał Górny <mgorny@gentoo.org> wrote:

> Support sync-clone-depth with the default set to 1. This allows the
> user to reduce the number of historical commits fetched along with the
> repository (git --depth).
> ---
>  man/portage.5                       |  4 ++++
>  pym/portage/repository/config.py    | 19 ++++++++++++++++++-
>  pym/portage/sync/modules/git/git.py |  6 +++++-
>  3 files changed, 27 insertions(+), 2 deletions(-)
> 
> diff --git a/man/portage.5 b/man/portage.5
> index f0b0e20..3fb511c 100644
> --- a/man/portage.5
> +++ b/man/portage.5
> @@ -903,6 +903,10 @@ since operations performed by these tools are
> inherently .B priority
>  Specifies priority of given repository.
>  .TP
> +.B sync\-clone\-depth
> +Specifies clone depth to use for DVCS repositories. Defaults to 1
> (only +the newest commit). If set to 0, the depth is unlimited.
> +.TP
>  .B sync\-cvs\-repo
>  Specifies CVS repository.
>  .TP
> diff --git a/pym/portage/repository/config.py
> b/pym/portage/repository/config.py index 7e17e02..2c4ce8a 100644
> --- a/pym/portage/repository/config.py
> +++ b/pym/portage/repository/config.py
> @@ -88,7 +88,8 @@ class RepoConfig(object):
>  		'profile_formats', 'sign_commit', 'sign_manifest',
> 'sync_cvs_repo', 'sync_type', 'sync_umask', 'sync_uri', 'sync_user',
> 'thin_manifest', 'update_changelog', 'user_location', '_eapis_banned',
> -		'_eapis_deprecated', '_masters_orig')
> +		'_eapis_deprecated', '_masters_orig',
> +		'sync_clone_depth')
>  
>  	def __init__(self, name, repo_opts, local_config=True):
>  		"""Build a RepoConfig with options in repo_opts
> @@ -176,6 +177,21 @@ class RepoConfig(object):
>  			auto_sync = auto_sync.strip().lower()
>  		self.auto_sync = auto_sync
>  
> +		sync_clone_depth = None
> +		if self.sync_type in ('git',):
> +			sync_clone_depth =
> repo_opts.get('sync-clone-depth')
> +			if sync_clone_depth is not None:
> +				try:
> +					sync_clone_depth =
> int(sync_clone_depth)
> +				except ValueError:
> +					sync_clone_depth = None
> +				else:
> +					if sync_clone_depth == 0:
> +						sync_clone_depth =
> None
> +			else:
> +				sync_clone_depth = 1
> +		self.sync_clone_depth = sync_clone_depth
> +
> 


This is wrong, and counter productive to the plugin-system, requiring
that checks be performed by the plugin.


I also prefer sync_depth as a variable name, which matches the other
names.  'sync-cvs-repo' is a legacy exception and is replaced by the
auto-sync option.  I was hoping the git migration was done before this
was released so it could more easily be removed.




> 		# Not implemented.
>  		format = repo_opts.get('format')
>  		if format is not None:
> @@ -489,6 +505,7 @@ class RepoConfigLoader(object):
>  						for k in ('aliases',
> 'auto_sync', 'eclass_overrides', 'force', 'masters', 'priority',
> 'sync_cvs_repo', 'sync_type', 'sync_umask', 'sync_uri', 'sync_user',
> +							'sync_clone_depth',
>  							):
>  							v =
> getattr(repos_conf_opts, k, None) if v is not None:
> diff --git a/pym/portage/sync/modules/git/git.py
> b/pym/portage/sync/modules/git/git.py index 35943dd..b97d501 100644
> --- a/pym/portage/sync/modules/git/git.py
> +++ b/pym/portage/sync/modules/git/git.py
> @@ -63,9 +63,13 @@ class GitSync(SyncBase):
>  		sync_uri = self.repo.sync_uri
>  		if sync_uri.startswith("file://"):
>  			sync_uri = sync_uri[6:]
> -		exitcode = portage.process.spawn_bash("cd %s ; %s
> clone %s ." % \
> +		depth_arg = ''
> +		if self.repo.sync_clone_depth is not None:
> +			depth_arg = '--depth %d ' %
> self.repo.sync_clone_depth
> +		exitcode = portage.process.spawn_bash("cd %s ; %s
> clone %s%s ." % \ (portage._shell_quote(self.repo.location),
>  			self.bin_command,
> +			depth_arg,
>  			portage._shell_quote(sync_uri)),
>  			**portage._native_kwargs(self.spawn_kwargs))
>  		if exitcode != os.EX_OK:



-- 
Brian Dolbec <dolsen>



^ permalink raw reply	[flat|nested] 7+ messages in thread

* [gentoo-portage-dev] [PATCH v2] sync: support sync-depth for DVCS-es (git --depth)
  2015-01-18  9:41 ` Brian Dolbec
@ 2015-01-18 10:33   ` Michał Górny
  2015-01-18 16:33     ` Brian Dolbec
  0 siblings, 1 reply; 7+ messages in thread
From: Michał Górny @ 2015-01-18 10:33 UTC (permalink / raw
  To: gentoo-portage-dev; +Cc: Michał Górny

Support sync-depth with the default set to 1. This allows the user
to reduce the number of historical commits fetched along with the
repository (git --depth).
---
 man/portage.5                            |  6 +++++-
 pym/portage/repository/config.py         |  6 +++++-
 pym/portage/sync/modules/git/__init__.py | 28 +++++++++++++++++++++++++++-
 pym/portage/sync/modules/git/git.py      |  6 +++++-
 4 files changed, 42 insertions(+), 4 deletions(-)

diff --git a/man/portage.5 b/man/portage.5
index f0b0e20..5d0e7c0 100644
--- a/man/portage.5
+++ b/man/portage.5
@@ -1,4 +1,4 @@
-.TH "PORTAGE" "5" "Jan 2015" "Portage VERSION" "Portage"
+TH "PORTAGE" "5" "Jan 2015" "Portage VERSION" "Portage"
 .SH NAME
 portage \- the heart of Gentoo
 .SH "DESCRIPTION"
@@ -906,6 +906,10 @@ Specifies priority of given repository.
 .B sync\-cvs\-repo
 Specifies CVS repository.
 .TP
+.B sync\-depth
+Specifies clone depth to use for DVCS repositories. Defaults to 1 (only
+the newest commit). If set to 0, the depth is unlimited.
+.TP
 .B sync\-type
 Specifies type of synchronization performed by `emerge \-\-sync`.
 .br
diff --git a/pym/portage/repository/config.py b/pym/portage/repository/config.py
index 7e17e02..84fc2ff 100644
--- a/pym/portage/repository/config.py
+++ b/pym/portage/repository/config.py
@@ -88,7 +88,8 @@ class RepoConfig(object):
 		'profile_formats', 'sign_commit', 'sign_manifest', 'sync_cvs_repo',
 		'sync_type', 'sync_umask', 'sync_uri', 'sync_user', 'thin_manifest',
 		'update_changelog', 'user_location', '_eapis_banned',
-		'_eapis_deprecated', '_masters_orig')
+		'_eapis_deprecated', '_masters_orig',
+		'sync_depth')
 
 	def __init__(self, name, repo_opts, local_config=True):
 		"""Build a RepoConfig with options in repo_opts
@@ -176,6 +177,8 @@ class RepoConfig(object):
 			auto_sync = auto_sync.strip().lower()
 		self.auto_sync = auto_sync
 
+		self.sync_depth = repo_opts.get('sync-depth')
+
 		# Not implemented.
 		format = repo_opts.get('format')
 		if format is not None:
@@ -489,6 +492,7 @@ class RepoConfigLoader(object):
 						for k in ('aliases', 'auto_sync', 'eclass_overrides',
 							'force', 'masters', 'priority', 'sync_cvs_repo',
 							'sync_type', 'sync_umask', 'sync_uri', 'sync_user',
+							'sync_depth',
 							):
 							v = getattr(repos_conf_opts, k, None)
 							if v is not None:
diff --git a/pym/portage/sync/modules/git/__init__.py b/pym/portage/sync/modules/git/__init__.py
index 833b389..a372881 100644
--- a/pym/portage/sync/modules/git/__init__.py
+++ b/pym/portage/sync/modules/git/__init__.py
@@ -5,7 +5,33 @@ doc = """Git plug-in module for portage.
 Performs a git pull on repositories."""
 __doc__ = doc[:]
 
+from portage.localization import _
 from portage.sync.config_checks import CheckSyncConfig
+from portage.util import writemsg_level
+
+
+class CheckGitConfig(CheckSyncConfig):
+	def __init__(self, repo, logger):
+		CheckSyncConfig.__init__(self, repo, logger)
+		self.checks.append('check_depth')
+
+	def check_depth(self):
+		d = self.repo.sync_depth
+		# default
+		self.repo.sync_depth = 1
+
+		if d is not None:
+			try:
+				d = int(d)
+			except ValueError:
+				writemsg_level("!!! %s\n" %
+					_("sync-depth value is not a number: '%s'")
+					% (d),
+					level=self.logger.ERROR, noiselevel=-1)
+			else:
+				if d == 0:
+					d = None
+				self.repo.sync_depth = d
 
 
 module_spec = {
@@ -23,7 +49,7 @@ module_spec = {
 				'exists': 'Returns a boolean of whether the specified dir ' +
 					'exists and is a valid Git repository',
 			},
-			'validate_config': CheckSyncConfig,
+			'validate_config': CheckGitConfig,
 		}
 	}
 }
diff --git a/pym/portage/sync/modules/git/git.py b/pym/portage/sync/modules/git/git.py
index 35943dd..d4f2cc1 100644
--- a/pym/portage/sync/modules/git/git.py
+++ b/pym/portage/sync/modules/git/git.py
@@ -63,9 +63,13 @@ class GitSync(SyncBase):
 		sync_uri = self.repo.sync_uri
 		if sync_uri.startswith("file://"):
 			sync_uri = sync_uri[6:]
-		exitcode = portage.process.spawn_bash("cd %s ; %s clone %s ." % \
+		depth_arg = ''
+		if self.repo.sync_depth is not None:
+			depth_arg = '--depth %d ' % self.repo.sync_depth
+		exitcode = portage.process.spawn_bash("cd %s ; %s clone %s%s ." % \
 			(portage._shell_quote(self.repo.location),
 			self.bin_command,
+			depth_arg,
 			portage._shell_quote(sync_uri)),
 			**portage._native_kwargs(self.spawn_kwargs))
 		if exitcode != os.EX_OK:
-- 
2.2.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [gentoo-portage-dev] [PATCH v2] sync: support sync-depth for DVCS-es (git --depth)
  2015-01-18 10:33   ` [gentoo-portage-dev] [PATCH v2] sync: support sync-depth " Michał Górny
@ 2015-01-18 16:33     ` Brian Dolbec
  2015-02-05 14:51       ` [gentoo-portage-dev] Regarding ACKs to the effect of "looks OK except..." Alexander Berntsen
  0 siblings, 1 reply; 7+ messages in thread
From: Brian Dolbec @ 2015-01-18 16:33 UTC (permalink / raw
  To: gentoo-portage-dev

On Sun, 18 Jan 2015 11:33:49 +0100
Michał Górny <mgorny@gentoo.org> wrote:

> Support sync-depth with the default set to 1. This allows the user
> to reduce the number of historical commits fetched along with the
> repository (git --depth).
> ---
>  man/portage.5                            |  6 +++++-
>  pym/portage/repository/config.py         |  6 +++++-
>  pym/portage/sync/modules/git/__init__.py | 28
> +++++++++++++++++++++++++++- pym/portage/sync/modules/git/git.py
> |  6 +++++- 4 files changed, 42 insertions(+), 4 deletions(-)
> 
> diff --git a/man/portage.5 b/man/portage.5
> index f0b0e20..5d0e7c0 100644
> --- a/man/portage.5
> +++ b/man/portage.5
> @@ -1,4 +1,4 @@
> -.TH "PORTAGE" "5" "Jan 2015" "Portage VERSION" "Portage"
> +TH "PORTAGE" "5" "Jan 2015" "Portage VERSION" "Portage"
>  .SH NAME
>  portage \- the heart of Gentoo
>  .SH "DESCRIPTION"
> @@ -906,6 +906,10 @@ Specifies priority of given repository.
>  .B sync\-cvs\-repo
>  Specifies CVS repository.
>  .TP
> +.B sync\-depth
> +Specifies clone depth to use for DVCS repositories. Defaults to 1
> (only +the newest commit). If set to 0, the depth is unlimited.
> +.TP
>  .B sync\-type
>  Specifies type of synchronization performed by `emerge \-\-sync`.
>  .br
> diff --git a/pym/portage/repository/config.py
> b/pym/portage/repository/config.py index 7e17e02..84fc2ff 100644
> --- a/pym/portage/repository/config.py
> +++ b/pym/portage/repository/config.py
> @@ -88,7 +88,8 @@ class RepoConfig(object):
>  		'profile_formats', 'sign_commit', 'sign_manifest',
> 'sync_cvs_repo', 'sync_type', 'sync_umask', 'sync_uri', 'sync_user',
> 'thin_manifest', 'update_changelog', 'user_location', '_eapis_banned',
> -		'_eapis_deprecated', '_masters_orig')
> +		'_eapis_deprecated', '_masters_orig',
> +		'sync_depth')
>  
>  	def __init__(self, name, repo_opts, local_config=True):
>  		"""Build a RepoConfig with options in repo_opts
> @@ -176,6 +177,8 @@ class RepoConfig(object):
>  			auto_sync = auto_sync.strip().lower()
>  		self.auto_sync = auto_sync
>  
> +		self.sync_depth = repo_opts.get('sync-depth')
> +

Yeah, just move this to sorted order like Arfrever said.  Otherwise it
looks good, ready to merge.



> 		# Not implemented.
>  		format = repo_opts.get('format')
>  		if format is not None:
> @@ -489,6 +492,7 @@ class RepoConfigLoader(object):
>  						for k in ('aliases',
> 'auto_sync', 'eclass_overrides', 'force', 'masters', 'priority',
> 'sync_cvs_repo', 'sync_type', 'sync_umask', 'sync_uri', 'sync_user',
> +							'sync_depth',
>  							):
>  							v =
> getattr(repos_conf_opts, k, None) if v is not None:
> diff --git a/pym/portage/sync/modules/git/__init__.py
> b/pym/portage/sync/modules/git/__init__.py index 833b389..a372881
> 100644 --- a/pym/portage/sync/modules/git/__init__.py
> +++ b/pym/portage/sync/modules/git/__init__.py
> @@ -5,7 +5,33 @@ doc = """Git plug-in module for portage.
>  Performs a git pull on repositories."""
>  __doc__ = doc[:]
>  
> +from portage.localization import _
>  from portage.sync.config_checks import CheckSyncConfig
> +from portage.util import writemsg_level
> +
> +
> +class CheckGitConfig(CheckSyncConfig):
> +	def __init__(self, repo, logger):
> +		CheckSyncConfig.__init__(self, repo, logger)
> +		self.checks.append('check_depth')
> +
> +	def check_depth(self):
> +		d = self.repo.sync_depth
> +		# default
> +		self.repo.sync_depth = 1
> +
> +		if d is not None:
> +			try:
> +				d = int(d)
> +			except ValueError:
> +				writemsg_level("!!! %s\n" %
> +					_("sync-depth value is not a
> number: '%s'")
> +					% (d),
> +					level=self.logger.ERROR,
> noiselevel=-1)
> +			else:
> +				if d == 0:
> +					d = None
> +				self.repo.sync_depth = d
>  
>  
>  module_spec = {
> @@ -23,7 +49,7 @@ module_spec = {
>  				'exists': 'Returns a boolean of
> whether the specified dir ' + 'exists and is a valid Git repository',
>  			},
> -			'validate_config': CheckSyncConfig,
> +			'validate_config': CheckGitConfig,
>  		}
>  	}
>  }
> diff --git a/pym/portage/sync/modules/git/git.py
> b/pym/portage/sync/modules/git/git.py index 35943dd..d4f2cc1 100644
> --- a/pym/portage/sync/modules/git/git.py
> +++ b/pym/portage/sync/modules/git/git.py
> @@ -63,9 +63,13 @@ class GitSync(SyncBase):
>  		sync_uri = self.repo.sync_uri
>  		if sync_uri.startswith("file://"):
>  			sync_uri = sync_uri[6:]
> -		exitcode = portage.process.spawn_bash("cd %s ; %s
> clone %s ." % \
> +		depth_arg = ''
> +		if self.repo.sync_depth is not None:
> +			depth_arg = '--depth %d ' %
> self.repo.sync_depth
> +		exitcode = portage.process.spawn_bash("cd %s ; %s
> clone %s%s ." % \ (portage._shell_quote(self.repo.location),
>  			self.bin_command,
> +			depth_arg,
>  			portage._shell_quote(sync_uri)),
>  			**portage._native_kwargs(self.spawn_kwargs))
>  		if exitcode != os.EX_OK:



-- 
Brian Dolbec <dolsen>



^ permalink raw reply	[flat|nested] 7+ messages in thread

* [gentoo-portage-dev] Regarding ACKs to the effect of "looks OK except..."
  2015-01-18 16:33     ` Brian Dolbec
@ 2015-02-05 14:51       ` Alexander Berntsen
  2015-02-05 16:34         ` Brian Dolbec
  0 siblings, 1 reply; 7+ messages in thread
From: Alexander Berntsen @ 2015-02-05 14:51 UTC (permalink / raw
  To: gentoo-portage-dev

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 18/01/15 17:33, Brian Dolbec wrote:
> Yeah, just move this to sorted order like Arfrever said.  Otherwise
> it looks good, ready to merge.
Friends,

I want to strongly discourage ACKs like "this looks good, but change
this one thing before you push". Anyone can make a typo or other error
in between such revisions. I would strongly prefer if we required a
review of the patch that is to be pushed.
- -- 
Alexander
bernalex@gentoo.org
https://secure.plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iF4EAREIAAYFAlTTg3YACgkQRtClrXBQc7VWowD9HU+6r60LVNVXRC6B2W5oetIg
+olHBuauHEA7FCVYANUA/04B9hq8Njy+osgtiWeI4ZFG0WukkKDzEsOS5+d6wDg6
=8gwQ
-----END PGP SIGNATURE-----


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [gentoo-portage-dev] Regarding ACKs to the effect of "looks OK except..."
  2015-02-05 14:51       ` [gentoo-portage-dev] Regarding ACKs to the effect of "looks OK except..." Alexander Berntsen
@ 2015-02-05 16:34         ` Brian Dolbec
  0 siblings, 0 replies; 7+ messages in thread
From: Brian Dolbec @ 2015-02-05 16:34 UTC (permalink / raw
  To: gentoo-portage-dev

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On Thu, 05 Feb 2015 15:51:34 +0100
Alexander Berntsen <bernalex@gentoo.org> wrote:

 
> On 18/01/15 17:33, Brian Dolbec wrote:
> > Yeah, just move this to sorted order like Arfrever said.  Otherwise
> > it looks good, ready to merge.
> Friends,
> 
> I want to strongly discourage ACKs like "this looks good, but change
> this one thing before you push". Anyone can make a typo or other error
> in between such revisions. I would strongly prefer if we required a
> review of the patch that is to be pushed.
> - -- 
> Alexander
> bernalex@gentoo.org
> https://secure.plaimi.net/~alexander
>

Fair enough :)

- -- 
Brian Dolbec <dolsen>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0

iQJ8BAEBCgBmBQJU05uLXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNUQ3Qzc0RTA4MUNDNzBEQjRBNEFBRjVG
QkJEMDg3Mjc1ODIwRUQ4AAoJEPu9CHJ1gg7Y6xcQALc71qmlrF6p53vQIqc4Zk4J
+KjUmpa3dHdOPfkYT9jEjpspsF8Y21n3BWuPfHiWsJ1Vgzlku6M19WSwTMAjHECV
3T460/CIJT2nJKPCLQLlzW9qaxmPntNqPMx9z7k2YCGBMtEX3VA2soP+HBqJ7il4
iFBUSiCZs68L4+0NFRgmTZox/CF6NS8t50sBZWe3vEtpIqGjidA96HlSGkmD60nM
RBRGydcU0OKNccc0s7bcE0PQFYEfcYIvoY39grTSZxZy78/tUStRqeV4VChxp042
oF/2nxGAjNhfFh2Erlv49FHJuUMQ2nRR3IkpIfvMR8WdKvKnAQ6m8WWAySnnVkOr
KqrAbnHWgFOMqDH8jBC9ny/6JRR675nB1mqKrCZQQt23p6ZGPEENKoxhepk5Mj0N
cXd/wTzQpswJUfejPoyuI3b/+IoXfEEpBuMvk7uAf4bPu00/4aL3NV5BqCYoVY4D
Zw0EHI/qVCEdlNAsj3TIQVazWW4W9HwzGJRYHoNoJdmBWVdyY/YFrQwshiAaPGpT
XKKl3Kd2UnsLm9INB3vlucxSWxwWFV6OlOg4klYHanDAxRqOXb+pUei+W3B/SBLe
iN7in8r1F9uIYg+fDbC2w4Qh2/u0FaNvnuoRwft/MD665lXIZkp7rBGaGo2NwCY/
WGW4YUtin0I8hS0HNnyQ
=zYYm
-----END PGP SIGNATURE-----

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2015-02-05 16:34 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-17 11:58 [gentoo-portage-dev] [PATCH] sync: support sync-clone-depth for DVCS-es (git --depth) Michał Górny
2015-01-17 22:04 ` Zac Medico
2015-01-18  9:41 ` Brian Dolbec
2015-01-18 10:33   ` [gentoo-portage-dev] [PATCH v2] sync: support sync-depth " Michał Górny
2015-01-18 16:33     ` Brian Dolbec
2015-02-05 14:51       ` [gentoo-portage-dev] Regarding ACKs to the effect of "looks OK except..." Alexander Berntsen
2015-02-05 16:34         ` Brian Dolbec

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox