From: Brian Dolbec <dolsen@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] Regarding ACKs to the effect of "looks OK except..."
Date: Thu, 5 Feb 2015 08:34:19 -0800 [thread overview]
Message-ID: <20150205083419.72867c68.dolsen@gentoo.org> (raw)
In-Reply-To: <54D38376.60901@gentoo.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
On Thu, 05 Feb 2015 15:51:34 +0100
Alexander Berntsen <bernalex@gentoo.org> wrote:
> On 18/01/15 17:33, Brian Dolbec wrote:
> > Yeah, just move this to sorted order like Arfrever said. Otherwise
> > it looks good, ready to merge.
> Friends,
>
> I want to strongly discourage ACKs like "this looks good, but change
> this one thing before you push". Anyone can make a typo or other error
> in between such revisions. I would strongly prefer if we required a
> review of the patch that is to be pushed.
> - --
> Alexander
> bernalex@gentoo.org
> https://secure.plaimi.net/~alexander
>
Fair enough :)
- --
Brian Dolbec <dolsen>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0
iQJ8BAEBCgBmBQJU05uLXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNUQ3Qzc0RTA4MUNDNzBEQjRBNEFBRjVG
QkJEMDg3Mjc1ODIwRUQ4AAoJEPu9CHJ1gg7Y6xcQALc71qmlrF6p53vQIqc4Zk4J
+KjUmpa3dHdOPfkYT9jEjpspsF8Y21n3BWuPfHiWsJ1Vgzlku6M19WSwTMAjHECV
3T460/CIJT2nJKPCLQLlzW9qaxmPntNqPMx9z7k2YCGBMtEX3VA2soP+HBqJ7il4
iFBUSiCZs68L4+0NFRgmTZox/CF6NS8t50sBZWe3vEtpIqGjidA96HlSGkmD60nM
RBRGydcU0OKNccc0s7bcE0PQFYEfcYIvoY39grTSZxZy78/tUStRqeV4VChxp042
oF/2nxGAjNhfFh2Erlv49FHJuUMQ2nRR3IkpIfvMR8WdKvKnAQ6m8WWAySnnVkOr
KqrAbnHWgFOMqDH8jBC9ny/6JRR675nB1mqKrCZQQt23p6ZGPEENKoxhepk5Mj0N
cXd/wTzQpswJUfejPoyuI3b/+IoXfEEpBuMvk7uAf4bPu00/4aL3NV5BqCYoVY4D
Zw0EHI/qVCEdlNAsj3TIQVazWW4W9HwzGJRYHoNoJdmBWVdyY/YFrQwshiAaPGpT
XKKl3Kd2UnsLm9INB3vlucxSWxwWFV6OlOg4klYHanDAxRqOXb+pUei+W3B/SBLe
iN7in8r1F9uIYg+fDbC2w4Qh2/u0FaNvnuoRwft/MD665lXIZkp7rBGaGo2NwCY/
WGW4YUtin0I8hS0HNnyQ
=zYYm
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2015-02-05 16:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-17 11:58 [gentoo-portage-dev] [PATCH] sync: support sync-clone-depth for DVCS-es (git --depth) Michał Górny
2015-01-17 22:04 ` Zac Medico
2015-01-18 9:41 ` Brian Dolbec
2015-01-18 10:33 ` [gentoo-portage-dev] [PATCH v2] sync: support sync-depth " Michał Górny
2015-01-18 16:33 ` Brian Dolbec
2015-02-05 14:51 ` [gentoo-portage-dev] Regarding ACKs to the effect of "looks OK except..." Alexander Berntsen
2015-02-05 16:34 ` Brian Dolbec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150205083419.72867c68.dolsen@gentoo.org \
--to=dolsen@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox