From: Brian Dolbec <dolsen@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] [PATCH] chpathtool.py: avoid unnecessary optparse import
Date: Mon, 19 Jan 2015 07:33:41 -0800 [thread overview]
Message-ID: <20150119073341.2c16af6b.dolsen@gentoo.org> (raw)
In-Reply-To: <1421658797-19090-1-git-send-email-zmedico@gentoo.org>
On Mon, 19 Jan 2015 01:13:17 -0800
Zac Medico <zmedico@gentoo.org> wrote:
> Since commit d217db2bc76e4c1a2e75685b4a00e25f7d8142a8, the optparse
> module has been imported unconditionally, even when the argparse
> module is available. Fix it to import optparse only if the argparse
> import fails.
>
> Fixes: d217db2bc76e ("Make use of optparse to fix argument parsing
> for Python 2.6 in bin/chpathtool.py.") ---
> bin/chpathtool.py | 22 ++++++++--------------
> 1 file changed, 8 insertions(+), 14 deletions(-)
>
>
Looks good. :)
--
Brian Dolbec <dolsen>
prev parent reply other threads:[~2015-01-19 15:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 9:13 [gentoo-portage-dev] [PATCH] chpathtool.py: avoid unnecessary optparse import Zac Medico
2015-01-19 15:33 ` Brian Dolbec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150119073341.2c16af6b.dolsen@gentoo.org \
--to=dolsen@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox