From: Brian Dolbec <dolsen@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] Re: [PATCH] TestFakedbapi: override EPREFIX for bug #492932
Date: Sun, 18 Jan 2015 08:54:24 -0800 [thread overview]
Message-ID: <20150118085424.386260c3.dolsen@gentoo.org> (raw)
In-Reply-To: <54BAB4FA.5050502@gentoo.org>
On Sat, 17 Jan 2015 11:16:10 -0800
Zac Medico <zmedico@gentoo.org> wrote:
> On 12/20/2014 01:11 PM, Zac Medico wrote:
> > For tests, override portage.const.EPREFIX in order to avoid unwanted
> > access to /etc/portage. This override may seem evil, but it is a
> > convenient way to simulate a prefix install, and it is reasonable
> > to do this because tests should be self-contained such that the
> > "real" value of portage.const.EPREFIX is entirely irrelevant.
>
> Any feedback on this? I think it's good to merge.
>
> I know it's ugly, but it's simple and it works. Maybe we'll come up
> with something fancier later on.
I didn't think it was "ugly", 2 lines of code and some comments...
yes, merge please
--
Brian Dolbec <dolsen>
prev parent reply other threads:[~2015-01-18 16:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-20 21:11 [gentoo-portage-dev] [PATCH] TestFakedbapi: override EPREFIX for bug #492932 Zac Medico
2015-01-17 19:16 ` [gentoo-portage-dev] " Zac Medico
2015-01-18 16:54 ` Brian Dolbec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150118085424.386260c3.dolsen@gentoo.org \
--to=dolsen@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox