From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 8A61D138A1A for ; Sun, 18 Jan 2015 16:49:17 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 135C7E08AE; Sun, 18 Jan 2015 16:49:17 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 90CE8E08AD for ; Sun, 18 Jan 2015 16:49:16 +0000 (UTC) Received: from big_daddy.dol-sen.ca (S010634bdfa9ecf80.vc.shawcable.net [96.49.31.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id C30123406B6 for ; Sun, 18 Jan 2015 16:49:15 +0000 (UTC) Date: Sun, 18 Jan 2015 08:48:56 -0800 From: Brian Dolbec To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH v2] git sync: replace 'git rev-parse' with safer '.git' check Message-ID: <20150118084856.0f74d613.dolsen@gentoo.org> In-Reply-To: <1421577264-4779-1-git-send-email-mgorny@gentoo.org> References: <54BADD32.1010907@gentoo.org> <1421577264-4779-1-git-send-email-mgorny@gentoo.org> Organization: Gentoo Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: 7efc0cbf-c6bb-4926-a21d-25b88e6949e4 X-Archives-Hash: 9948515ce4e832bf87e80a6760fb2e44 On Sun, 18 Jan 2015 11:34:24 +0100 Micha=C5=82 G=C3=B3rny wrote: > The 'git rev-parse' could succeed if one of the parent directories > contained a git repository, and it also had unwanted error output. > Instead, just check whether the '.git' directory exists. > --- > pym/portage/sync/modules/git/git.py | 14 +------------- > 1 file changed, 1 insertion(+), 13 deletions(-) >=20 > Looks good. Thanks. --=20 Brian Dolbec