From: Brian Dolbec <dolsen@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] [PATCH v2] git sync: replace 'git rev-parse' with safer '.git' check
Date: Sun, 18 Jan 2015 08:48:56 -0800 [thread overview]
Message-ID: <20150118084856.0f74d613.dolsen@gentoo.org> (raw)
In-Reply-To: <1421577264-4779-1-git-send-email-mgorny@gentoo.org>
On Sun, 18 Jan 2015 11:34:24 +0100
Michał Górny <mgorny@gentoo.org> wrote:
> The 'git rev-parse' could succeed if one of the parent directories
> contained a git repository, and it also had unwanted error output.
> Instead, just check whether the '.git' directory exists.
> ---
> pym/portage/sync/modules/git/git.py | 14 +-------------
> 1 file changed, 1 insertion(+), 13 deletions(-)
>
>
Looks good. Thanks.
--
Brian Dolbec <dolsen>
prev parent reply other threads:[~2015-01-18 16:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-17 12:28 [gentoo-portage-dev] [PATCH] git sync: silence 'git rev-parse' errors Michał Górny
2015-01-17 22:07 ` Zac Medico
2015-01-18 0:31 ` Michał Górny
2015-01-18 0:52 ` Zac Medico
2015-01-18 10:34 ` [gentoo-portage-dev] [PATCH v2] git sync: replace 'git rev-parse' with safer '.git' check Michał Górny
2015-01-18 16:48 ` Brian Dolbec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150118084856.0f74d613.dolsen@gentoo.org \
--to=dolsen@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox