From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id B6F32138A1A for ; Sun, 18 Jan 2015 16:36:49 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 5DB38E089F; Sun, 18 Jan 2015 16:36:48 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id DE528E088C for ; Sun, 18 Jan 2015 16:36:47 +0000 (UTC) Received: from big_daddy.dol-sen.ca (S010634bdfa9ecf80.vc.shawcable.net [96.49.31.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id 400013406DE for ; Sun, 18 Jan 2015 16:36:47 +0000 (UTC) Date: Sun, 18 Jan 2015 08:36:28 -0800 From: Brian Dolbec To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH v2] svn sync: fix the module Message-ID: <20150118083628.1d382a63.dolsen@gentoo.org> In-Reply-To: <1421577318-4960-1-git-send-email-mgorny@gentoo.org> References: <54BAFA8C.7030100@gentoo.org> <1421577318-4960-1-git-send-email-mgorny@gentoo.org> Organization: Gentoo Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: f5322167-0756-450b-a7e5-5763952fe1ab X-Archives-Hash: 154a2bafec9a5f179cea2b2413776288 On Sun, 18 Jan 2015 11:35:18 +0100 Micha=C5=82 G=C3=B3rny wrote: > Fix the svn sync module since it doesn't work at all right now. More > specifically: >=20 > 1. add exists() method that checks for the '.svn' directory to > determine whether the repository was checked out already. >=20 > 2. Fix the initial clone to use valid svn commands. Do not remove > the just-created (in pre_sync()) directory to avoid permission issues, > just run checkout on top of it. >=20 > 3. Fix the sync method to run update unconditionally to whether the > URI starts with svn:// or not. In fact, remove the whole check since > it doesn't serve any purpose. > --- > pym/portage/sync/modules/svn/svn.py | 42 > +++++++++++++++---------------------- 1 file changed, 17 > insertions(+), 25 deletions(-) >=20 > Looks good, thank you for this update. --=20 Brian Dolbec