Re: [gentoo-portage-dev] [PATCH v2] svn sync: fix the module

[Brian Dolbec <dolsen@gentoo.org>]

On Sun, 18 Jan 2015 11:35:18 +0100
Michał Górny <mgorny@gentoo.org> wrote:

> Fix the svn sync module since it doesn't work at all right now. More
> specifically:
> 
> 1. add exists() method that checks for the '.svn' directory to
> determine whether the repository was checked out already.
> 
> 2. Fix the initial clone to use valid svn commands. Do not remove
> the just-created (in pre_sync()) directory to avoid permission issues,
> just run checkout on top of it.
> 
> 3. Fix the sync method to run update unconditionally to whether the
> URI starts with svn:// or not. In fact, remove the whole check since
> it doesn't serve any purpose.
> ---
>  pym/portage/sync/modules/svn/svn.py | 42
> +++++++++++++++---------------------- 1 file changed, 17
> insertions(+), 25 deletions(-)
> 
>

Looks good, thank you for this update.

-- 
Brian Dolbec <dolsen>