From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 00A54138A1A for ; Sun, 18 Jan 2015 09:49:39 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id DDF3CE0912; Sun, 18 Jan 2015 09:49:37 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 4C906E08F1 for ; Sun, 18 Jan 2015 09:49:37 +0000 (UTC) Received: from big_daddy.dol-sen.ca (S010634bdfa9ecf80.vc.shawcable.net [96.49.31.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id 2B5933406DD for ; Sun, 18 Jan 2015 09:49:36 +0000 (UTC) Date: Sun, 18 Jan 2015 01:49:16 -0800 From: Brian Dolbec To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH] sync: fix module_names enumeration Message-ID: <20150118014916.01c20565.dolsen@gentoo.org> In-Reply-To: <1421500603-15692-1-git-send-email-mgorny@gentoo.org> References: <1421500603-15692-1-git-send-email-mgorny@gentoo.org> Organization: Gentoo Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: 3ce8787d-6d9b-43b6-b093-d89abc8e6f8d X-Archives-Hash: 8e8d75bbf1a73cd54251a5510ce38bfb On Sat, 17 Jan 2015 14:16:43 +0100 Micha=C5=82 G=C3=B3rny wrote: > Fix module_names enumeration to consider all modules. Before, the > first module on the list was omitted ('cvs' in this case). >=20 > Another thing is, the CVS module is completely, utterly and inevitably > broken. And the whole syncing thing is a great pile of terribly > mis-designed, unnecessarily complex code which can't work unless it is > worked around like git module does... > --- Really??? this just shows how immature you really are. This type of commit message does not belong in __ANY__ repo, therefore this is rejected. > pym/portage/sync/controller.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/pym/portage/sync/controller.py > b/pym/portage/sync/controller.py index 9001298..3d217db 100644 > --- a/pym/portage/sync/controller.py > +++ b/pym/portage/sync/controller.py > @@ -119,7 +119,7 @@ class SyncManager(object): > self.callback =3D callback or self._sync_callback > self.repo =3D repo > self.exitcode =3D 1 > - if repo.sync_type in self.module_names[1:]: > + if repo.sync_type in self.module_names: > tasks =3D > [self.module_controller.get_class(repo.sync_type)] else: > msg =3D "\n%s: Sync module '%s' is not an > installed/known type'\n" \ thanks for the one line patch. It was something I missed removing when I first ported the controller module from the emaint one which pre-pends an 'all' to the list. --=20 Brian Dolbec