Re: [gentoo-portage-dev] [PATCH] sync: fix module_names enumeration

[Brian Dolbec <dolsen@gentoo.org>]

On Sat, 17 Jan 2015 14:16:43 +0100
Michał Górny <mgorny@gentoo.org> wrote:

> Fix module_names enumeration to consider all modules. Before, the
> first module on the list was omitted ('cvs' in this case).
> 
> Another thing is, the CVS module is completely, utterly and inevitably
> broken. And the whole syncing thing is a great pile of terribly
> mis-designed, unnecessarily complex code which can't work unless it is
> worked around like git module does...
> ---


Really???  this just shows how immature you really are.  This type of
commit message does not belong in __ANY__ repo, therefore this is
rejected.


>  pym/portage/sync/controller.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/pym/portage/sync/controller.py
> b/pym/portage/sync/controller.py index 9001298..3d217db 100644
> --- a/pym/portage/sync/controller.py
> +++ b/pym/portage/sync/controller.py
> @@ -119,7 +119,7 @@ class SyncManager(object):
>  		self.callback = callback or self._sync_callback
>  		self.repo = repo
>  		self.exitcode = 1
> -		if repo.sync_type in self.module_names[1:]:
> +		if repo.sync_type in self.module_names:
>  			tasks =
> [self.module_controller.get_class(repo.sync_type)] else:
>  			msg = "\n%s: Sync module '%s' is not an
> installed/known type'\n" \

thanks for the one line patch.  It was something I missed removing when
I first ported the controller module from the emaint one which
pre-pends an 'all' to the list.

-- 
Brian Dolbec <dolsen>