From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id BC59F138A1A for ; Thu, 15 Jan 2015 00:59:46 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C25C5E0849; Thu, 15 Jan 2015 00:59:44 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 42F48E0845 for ; Thu, 15 Jan 2015 00:59:44 +0000 (UTC) Received: from big_daddy.dol-sen.ca (S010634bdfa9ecf80.vc.shawcable.net [96.49.31.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id D6AC9340682 for ; Thu, 15 Jan 2015 00:59:42 +0000 (UTC) Date: Wed, 14 Jan 2015 16:59:26 -0800 From: Brian Dolbec To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] Re: [PATCH] emerge: add --changed-deps/--binpkg-changed-deps (282927) Message-ID: <20150114165926.05ec0efb.dolsen@gentoo.org> In-Reply-To: <54B6FB39.2020600@gentoo.org> References: <1419367536-30393-1-git-send-email-zmedico@gentoo.org> <54B6FB39.2020600@gentoo.org> Organization: Gentoo Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: d3fb62a4-c147-4da0-b84f-5e9b5c9217fc X-Archives-Hash: 5cdfc4060182924fcef5f18d07ed5c35 On Wed, 14 Jan 2015 15:26:49 -0800 Zac Medico wrote: > On 12/23/2014 12:45 PM, Zac Medico wrote: > > The @changed-deps set is useful, but it has limitations similar to > > the @installed set (see bug #387059), which can make it unsuitable > > for use when updating the whole system. Therefore, implement two > > new options that are analogous to --newuse and > > --binpkg-respect-use, called --changed-deps and > > --binpkg-changed-deps. > > > > The rationale for having a separate --binpkg-* option is the same in > > both cases: depending on the situation, people may want different > > behavior for binary packages. For example, just like > > ---binpkg-respect-use is automatically enabled if the user has not > > specified --usepkgonly, so is --binpkg-changed-deps (though the user > > can explicitly override the automatic behavior). In both cases, > > inconsistencies in dependencies are automatically avoided, > > increasing the probability of a successful dependency calculation. > > > > X-Gentoo-Bug: 282927 > > X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=282927 > > --- > > man/emerge.1 | 22 +++- > > pym/_emerge/create_depgraph_params.py | 16 +++ > > pym/_emerge/depgraph.py | 138 > > ++++++++++++++++++++++-- > > pym/_emerge/main.py | 26 +++++ > > pym/portage/dep/_slot_operator.py | 13 +++ > > pym/portage/tests/resolver/test_changed_deps.py | 120 > > +++++++++++++++++++++ 6 files changed, 323 insertions(+), 12 > > deletions(-) create mode 100644 > > pym/portage/tests/resolver/test_changed_deps.py > > Any feedback on this? I think it's good to merge. yeah, looks good, merge approved :) -- Brian Dolbec