From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 695D4138A1A for ; Mon, 12 Jan 2015 06:06:31 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 36C49E0845; Mon, 12 Jan 2015 06:06:28 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 8E839E0843 for ; Mon, 12 Jan 2015 06:06:27 +0000 (UTC) Received: from big_daddy.dol-sen.ca (S010634bdfa9ecf80.vc.shawcable.net [96.49.31.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id AF338340686 for ; Mon, 12 Jan 2015 06:06:25 +0000 (UTC) Date: Sun, 11 Jan 2015 22:06:08 -0800 From: Brian Dolbec To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH] dispatch_conf: factor out _archive_copy Message-ID: <20150111220608.18eac111.dolsen@gentoo.org> In-Reply-To: <1421039815-27793-1-git-send-email-zmedico@gentoo.org> References: <20150111180725.68bde153.dolsen@gentoo.org> <1421039815-27793-1-git-send-email-zmedico@gentoo.org> Organization: Gentoo Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: dd2750b5-0a42-4ad2-8b0e-847f14a623b3 X-Archives-Hash: 2547aeb95dec8df62249bd85c61131a4 On Sun, 11 Jan 2015 21:16:55 -0800 Zac Medico wrote: > This eliminates 4 instances of duplicate code from the rcs_archive and > file_archive functions. > > Suggested-by: Brian Dolbec > --- Looks much better, Thank you, merge both patches please -- Brian Dolbec