public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-portage-dev] [PATCH] portage.tests.dbapi.test_portdb_cache: Delete deprecated code.
@ 2014-12-13 16:52 Arfrever Frehtes Taifersar Arahesis
  2014-12-13 18:14 ` Zac Medico
  0 siblings, 1 reply; 3+ messages in thread
From: Arfrever Frehtes Taifersar Arahesis @ 2014-12-13 16:52 UTC (permalink / raw
  To: Gentoo Portage Development


[-- Attachment #1.1: Type: Text/Plain, Size: 224 bytes --]

[[[
portage.tests.dbapi.test_portdb_cache: Delete deprecated code.

9 calls to deprecated portage.repository.config.RepoConfigLoader.mainRepoLocation()
function have been deleted.
]]]

--
Arfrever Frehtes Taifersar Arahesis

[-- Attachment #1.2: portage.patch --]
[-- Type: text/x-patch, Size: 3635 bytes --]

--- pym/portage/tests/dbapi/test_portdb_cache.py
+++ pym/portage/tests/dbapi/test_portdb_cache.py
@@ -47,7 +47,7 @@
 			(lambda: not os.path.exists(md5_cache_dir),),
 			python_cmd + (textwrap.dedent("""
 				import os, sys, portage
-				if portage.portdb.repositories.mainRepoLocation() in portage.portdb._pregen_auxdb:
+				if portage.portdb.repositories['test_repo'].location in portage.portdb._pregen_auxdb:
 					sys.exit(1)
 			"""),),
 
@@ -56,13 +56,13 @@
 			(lambda: os.path.exists(md5_cache_dir),),
 			python_cmd + (textwrap.dedent("""
 				import os, sys, portage
-				if portage.portdb.repositories.mainRepoLocation() not in portage.portdb._pregen_auxdb:
+				if portage.portdb.repositories['test_repo'].location not in portage.portdb._pregen_auxdb:
 					sys.exit(1)
 			"""),),
 			python_cmd + (textwrap.dedent("""
 				import os, sys, portage
 				from portage.cache.flat_hash import md5_database
-				if not isinstance(portage.portdb._pregen_auxdb[portage.portdb.repositories.mainRepoLocation()], md5_database):
+				if not isinstance(portage.portdb._pregen_auxdb[portage.portdb.repositories['test_repo'].location], md5_database):
 					sys.exit(1)
 			"""),),
 
@@ -73,13 +73,13 @@
 			(lambda: os.path.exists(md5_cache_dir),),
 			python_cmd + (textwrap.dedent("""
 				import os, sys, portage
-				if portage.portdb.repositories.mainRepoLocation() not in portage.portdb._pregen_auxdb:
+				if portage.portdb.repositories['test_repo'].location not in portage.portdb._pregen_auxdb:
 					sys.exit(1)
 			"""),),
 			python_cmd + (textwrap.dedent("""
 				import os, sys, portage
 				from portage.cache.flat_hash import md5_database
-				if not isinstance(portage.portdb._pregen_auxdb[portage.portdb.repositories.mainRepoLocation()], md5_database):
+				if not isinstance(portage.portdb._pregen_auxdb[portage.portdb.repositories['test_repo'].location], md5_database):
 					sys.exit(1)
 			"""),),
 
@@ -90,13 +90,13 @@
 				("cache-formats = pms md5-dict", layout_conf_path,)))),
 			(portage_python, "-b", "-Wd", "-Wi::DeprecationWarning", "-c") + (textwrap.dedent("""
 				import os, sys, portage
-				if portage.portdb.repositories.mainRepoLocation() not in portage.portdb._pregen_auxdb:
+				if portage.portdb.repositories['test_repo'].location not in portage.portdb._pregen_auxdb:
 					sys.exit(1)
 			"""),),
 			(portage_python, "-b", "-Wd", "-Wi::DeprecationWarning", "-c") + (textwrap.dedent("""
 				import os, sys, portage
 				from portage.cache.metadata import database as pms_database
-				if not isinstance(portage.portdb._pregen_auxdb[portage.portdb.repositories.mainRepoLocation()], pms_database):
+				if not isinstance(portage.portdb._pregen_auxdb[portage.portdb.repositories['test_repo'].location], pms_database):
 					sys.exit(1)
 			"""),),
 
@@ -105,13 +105,13 @@
 			(BASH_BINARY, "-c", "rm %s" % portage._shell_quote(layout_conf_path)),
 			python_cmd + (textwrap.dedent("""
 				import os, sys, portage
-				if portage.portdb.repositories.mainRepoLocation() not in portage.portdb._pregen_auxdb:
+				if portage.portdb.repositories['test_repo'].location not in portage.portdb._pregen_auxdb:
 					sys.exit(1)
 			"""),),
 			python_cmd + (textwrap.dedent("""
 				import os, sys, portage
 				from portage.cache.flat_hash import md5_database
-				if not isinstance(portage.portdb._pregen_auxdb[portage.portdb.repositories.mainRepoLocation()], md5_database):
+				if not isinstance(portage.portdb._pregen_auxdb[portage.portdb.repositories['test_repo'].location], md5_database):
 					sys.exit(1)
 			"""),),
 		)

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [gentoo-portage-dev] [PATCH] portage.tests.dbapi.test_portdb_cache: Delete deprecated code.
  2014-12-13 16:52 [gentoo-portage-dev] [PATCH] portage.tests.dbapi.test_portdb_cache: Delete deprecated code Arfrever Frehtes Taifersar Arahesis
@ 2014-12-13 18:14 ` Zac Medico
  2014-12-15 14:15   ` Brian Dolbec
  0 siblings, 1 reply; 3+ messages in thread
From: Zac Medico @ 2014-12-13 18:14 UTC (permalink / raw
  To: gentoo-portage-dev

On 12/13/2014 08:52 AM, Arfrever Frehtes Taifersar Arahesis wrote:
> [[[
> portage.tests.dbapi.test_portdb_cache: Delete deprecated code.
> 
> 9 calls to deprecated portage.repository.config.RepoConfigLoader.mainRepoLocation()
> function have been deleted.
> ]]]
> 
> --
> Arfrever Frehtes Taifersar Arahesis
> 

LGTM.
-- 
Thanks,
Zac


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [gentoo-portage-dev] [PATCH] portage.tests.dbapi.test_portdb_cache: Delete deprecated code.
  2014-12-13 18:14 ` Zac Medico
@ 2014-12-15 14:15   ` Brian Dolbec
  0 siblings, 0 replies; 3+ messages in thread
From: Brian Dolbec @ 2014-12-15 14:15 UTC (permalink / raw
  To: gentoo-portage-dev

On Sat, 13 Dec 2014 10:14:15 -0800
Zac Medico <zmedico@gentoo.org> wrote:

> On 12/13/2014 08:52 AM, Arfrever Frehtes Taifersar Arahesis wrote:
> > [[[
> > portage.tests.dbapi.test_portdb_cache: Delete deprecated code.
> > 
> > 9 calls to deprecated
> > portage.repository.config.RepoConfigLoader.mainRepoLocation()
> > function have been deleted. ]]]
> > 
> > --
> > Arfrever Frehtes Taifersar Arahesis
> > 
> 
> LGTM.

yup, merge

-- 
Brian Dolbec <dolsen>



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-12-15 14:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-13 16:52 [gentoo-portage-dev] [PATCH] portage.tests.dbapi.test_portdb_cache: Delete deprecated code Arfrever Frehtes Taifersar Arahesis
2014-12-13 18:14 ` Zac Medico
2014-12-15 14:15   ` Brian Dolbec

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox