[gentoo-portage-dev] [PATCH] portage.dbapi.bintree.binarytree: Delete PORTDIR-reliant microoptimization in index of binary packages

[gentoo-portage-dev] [PATCH] portage.dbapi.bintree.binarytree: Delete PORTDIR-reliant microoptimization in index of binary packages

[Arfrever Frehtes Taifersar Arahesis]

[-- Attachment #1.1: Type: Text/Plain, Size: 220 bytes --]

[[[
portage.dbapi.bintree.binarytree: Delete PORTDIR-reliant microoptimization in index of binary packages.

This microoptimization cannot work when no main repository exists.
]]]

--
Arfrever Frehtes Taifersar Arahesis

[-- Attachment #1.2: portage.patch --]
[-- Type: text/x-patch, Size: 716 bytes --]

--- pym/portage/dbapi/bintree.py
+++ pym/portage/dbapi/bintree.py
@@ -360,16 +360,6 @@
 				"repository"   : "",
 			}
 
-			# It is especially important to populate keys like
-			# "repository" that save space when entries can
-			# inherit them from the header. If an existing
-			# pkgindex header already defines these keys, then
-			# they will appropriately override our defaults.
-			main_repo = self.settings.repositories.mainRepo()
-			if main_repo is not None and not main_repo.missing_repo_name:
-				self._pkgindex_default_header_data["repository"] = \
-					main_repo.name
-
 			self._pkgindex_translated_keys = (
 				("DESCRIPTION"   ,   "DESC"),
 				("repository"    ,   "REPO"),

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [gentoo-portage-dev] [PATCH] portage.dbapi.bintree.binarytree: Delete PORTDIR-reliant microoptimization in index of binary packages

[Zac Medico]

On 12/13/2014 08:26 AM, Arfrever Frehtes Taifersar Arahesis wrote:
> [[[
> portage.dbapi.bintree.binarytree: Delete PORTDIR-reliant microoptimization in index of binary packages.
> 
> This microoptimization cannot work when no main repository exists.
> ]]]
> 
> --
> Arfrever Frehtes Taifersar Arahesis
> 

LGTM.

I guess we could scan the package list and set the default repository
value to the repository with maximum occurrences. However, it's not very
important.
-- 
Thanks,
Zac

Re: [gentoo-portage-dev] [PATCH] portage.dbapi.bintree.binarytree: Delete PORTDIR-reliant microoptimization in index of binary packages

[Brian Dolbec]

[-- Attachment #1: Type: text/plain, Size: 399 bytes --]

On Sat, 13 Dec 2014 17:26:23 +0100
Arfrever Frehtes Taifersar Arahesis <arfrever.fta@gmail.com> wrote:

> [[[
> portage.dbapi.bintree.binarytree: Delete PORTDIR-reliant
> microoptimization in index of binary packages.
> 
> This microoptimization cannot work when no main repository exists.
> ]]]
> 
> --
> Arfrever Frehtes Taifersar Arahesis

lg, merge

-- 
Brian Dolbec <dolsen>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 951 bytes --]