From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 86AB21389E2 for ; Sun, 7 Dec 2014 18:39:20 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 71D58E0899; Sun, 7 Dec 2014 18:39:19 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 834A9E06CC for ; Sun, 7 Dec 2014 18:39:18 +0000 (UTC) Received: from pomiot.lan (mgorny-1-pt.tunnel.tserv28.waw1.ipv6.he.net [IPv6:2001:470:70:353::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 2B68134055A; Sun, 7 Dec 2014 18:39:15 +0000 (UTC) Date: Sun, 7 Dec 2014 19:39:04 +0100 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: Zac Medico Cc: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH 4/4] sync: Add backwards compat with SYNC_{UMASK,USER} variables Message-ID: <20141207193904.1abe1b31@pomiot.lan> In-Reply-To: <54849D88.40308@gentoo.org> References: <1417824216-7990-1-git-send-email-mgorny@gentoo.org> <1417824216-7990-5-git-send-email-mgorny@gentoo.org> <5483FE7D.3060302@gentoo.org> <20141207092207.7070d75c@pomiot.lan> <54841813.8060203@gentoo.org> <20141207100631.2f8a813c@pomiot.lan> <54849D88.40308@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/G2qmp9ZmoDbhldHyvii_wQK"; protocol="application/pgp-signature" X-Archives-Salt: 6ced31f5-879f-4ff4-a387-5a43e881bc37 X-Archives-Hash: f1e1e89b12db931558545adc1cebbca3 --Sig_/G2qmp9ZmoDbhldHyvii_wQK Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Dnia 2014-12-07, o godz. 10:33:44 Zac Medico napisa=C5=82(a): > On 12/07/2014 01:06 AM, Micha=C5=82 G=C3=B3rny wrote: > > Dnia 2014-12-07, o godz. 01:04:19 > > Zac Medico napisa=C5=82(a): > >=20 > >> On 12/07/2014 12:22 AM, Micha=C5=82 G=C3=B3rny wrote: > >>> Dnia 2014-12-06, o godz. 23:15:09 > >>> Zac Medico napisa=C5=82(a): > >>> > >>>> On 12/05/2014 04:03 PM, Micha=C5=82 G=C3=B3rny wrote: > >>>>> Support SYNC_UMASK and SYNC_USER variables that were used in Funtoo > >>>>> Portage, as fallbacks to sync-umask and sync-user repo keys. > >>>>> --- > >>>>> pym/portage/package/ebuild/_config/special_env_vars.py | 2 +- > >>>>> pym/portage/package/ebuild/config.py | 12 ++++++= ++++++ > >>>>> pym/portage/repository/config.py | 13 ++++++= +++++++ > >>>>> 3 files changed, 26 insertions(+), 1 deletion(-) > >>>> > >>>> Why should we add backward compatibility code for something that was > >>>> never supported in the master branch? > >>> > >>> I just thought it wouldn't hurt if we're backporting features. > >> > >> Adding extra code for new redundant variables seems undesirable. Are > >> they somehow better than using equivalent repos.conf [DEFAULT] settings > >> for sync-user and sync-mask? > >=20 > > They're easier to set in env than the fancy PORTAGE_REPOSITORIES. >=20 > Do these settings commonly need to be overridden in the env? I have no clue. I just don't want users to lose functionality when it doesn't require much effort (anymore, consider I've lost over an hour to figure out why settings are incomplete...). --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/G2qmp9ZmoDbhldHyvii_wQK Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJUhJ7IXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2REJCMDdDQzRGMERBRDA2RUEwQUZFNDFC MDdBMUFFQUVGQjQ0NjRFAAoJELB6GurvtEZOxbMP/RDFuabm0XsPWUWhMb4RjxZV JDHKNRlGOhHFY8mthZ7F+Ia6Fh1NtfVJi1nw98IQcUYlILfzfMF1gbWfw9iTmjrh 9neE6i+0bzQOhDyXgRfIgo96OEMCgRA3Ye4fDSQu9Yi2a/IfWQBjanCoiGwid/Vw 5Jqxm/3NtbS6rhIUiq3PDWugSrfCJ0+/mzV6KiPaRbc4T/TXnc2DXq7eH1lrryCW kjDhL3T5WKb62r5pEVvpBRWCD1MYccnURLaTy4RzonamarKUhev8nUQqtPqgeKM6 vXzr7fpSc/iE9oec4M8DjnB5IiVdwUa6VMLKQKkxy53pxCaZo+tocfIqW6GN+fLU RgweBUV86rzOlnfLU8Sgr0c69lekOEFCEsTbww0xMRLXrS2ZsaAvJGFQDYZh4yNL grhlB5CnVY0wCa/+fM4ukQCVwUSnbR80FTiMv50nZCTSXqOdBqS0M0qs/YDCc/3s y9lrdkgCddWlIhiPxTz0wKIp6e6ayrK5aHU/9u74OiEUuZEA8gvejuNgCmoAQJg3 +exRbZN10tz49oBBeFltNeey4NTonImqWW/uKu4UBhLmpYGm2PUTI4hCbQQPExQI ztrxZkQgCd0wYPeugpE23jFXG2HBrODkT6WBH/INeyppCy1Rc6phZl8/TjIEhcvk 7BXRKiRJrhwkvQGKk+Ya =/tmf -----END PGP SIGNATURE----- --Sig_/G2qmp9ZmoDbhldHyvii_wQK--