From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 839FF1389E2 for ; Sun, 7 Dec 2014 09:06:42 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B7D1CE0930; Sun, 7 Dec 2014 09:06:40 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 3726EE07E8 for ; Sun, 7 Dec 2014 09:06:40 +0000 (UTC) Received: from pomiot.lan (mgorny-1-pt.tunnel.tserv28.waw1.ipv6.he.net [IPv6:2001:470:70:353::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 35586340509; Sun, 7 Dec 2014 09:06:38 +0000 (UTC) Date: Sun, 7 Dec 2014 10:06:31 +0100 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: Zac Medico Cc: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH 4/4] sync: Add backwards compat with SYNC_{UMASK,USER} variables Message-ID: <20141207100631.2f8a813c@pomiot.lan> In-Reply-To: <54841813.8060203@gentoo.org> References: <1417824216-7990-1-git-send-email-mgorny@gentoo.org> <1417824216-7990-5-git-send-email-mgorny@gentoo.org> <5483FE7D.3060302@gentoo.org> <20141207092207.7070d75c@pomiot.lan> <54841813.8060203@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/hD8Oq3YrUaNup/ThHb8wffE"; protocol="application/pgp-signature" X-Archives-Salt: 2682c0cd-024f-49bb-b3de-4c558753f5e0 X-Archives-Hash: 0d993f7c38fdc08e905917cab11f644a --Sig_/hD8Oq3YrUaNup/ThHb8wffE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Dnia 2014-12-07, o godz. 01:04:19 Zac Medico napisa=C5=82(a): > On 12/07/2014 12:22 AM, Micha=C5=82 G=C3=B3rny wrote: > > Dnia 2014-12-06, o godz. 23:15:09 > > Zac Medico napisa=C5=82(a): > >=20 > >> On 12/05/2014 04:03 PM, Micha=C5=82 G=C3=B3rny wrote: > >>> Support SYNC_UMASK and SYNC_USER variables that were used in Funtoo > >>> Portage, as fallbacks to sync-umask and sync-user repo keys. > >>> --- > >>> pym/portage/package/ebuild/_config/special_env_vars.py | 2 +- > >>> pym/portage/package/ebuild/config.py | 12 ++++++++= ++++ > >>> pym/portage/repository/config.py | 13 ++++++++= +++++ > >>> 3 files changed, 26 insertions(+), 1 deletion(-) > >> > >> Why should we add backward compatibility code for something that was > >> never supported in the master branch? > >=20 > > I just thought it wouldn't hurt if we're backporting features. >=20 > Adding extra code for new redundant variables seems undesirable. Are > they somehow better than using equivalent repos.conf [DEFAULT] settings > for sync-user and sync-mask? They're easier to set in env than the fancy PORTAGE_REPOSITORIES. --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/hD8Oq3YrUaNup/ThHb8wffE Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJUhBiXXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2REJCMDdDQzRGMERBRDA2RUEwQUZFNDFC MDdBMUFFQUVGQjQ0NjRFAAoJELB6GurvtEZOcekP/iK183bKgar16VEUgk2z0mSk mcZ8aC2qxMZqmBJSAIHqTLlwhtlWSpGhB1cIseD+L+SJt16HcuUo0811WDNn4qvL 0CAJb+mlSBC77zH5nJeYbPRI5H2uDNy5HJTkg3O9E+bkqNN7AdfQa9y7QQoAm1K7 Nf4C4KyD9uTRvXHfX5BfRQftK2XTDMcOJN+C1uL9mC7OdY+nDCYyGyQqPtorIOru OjrDH1aVv6L86lqkmXHXCjBISnXmWC31osC8R2MMvJklTvXNpqDOAmlWDvOILaeb 143fKeGejeqvzDIocPdBOV9ia9TJBvpjy6pDwxOL9waFRL5l7+medo0kYupFqOZK LBpz1iZ3TkklvXN/kNMKcKkpIVL6XyP9lxeEU9aBx+zE/C1xm1RlcCMJ5iql4/BK ul741aQLduMQwXjVaLyWaVgEvyHHBodqayiBV6TmrPlhAvBMP89yKU0BJDQFXcdL ggojRJOgXyvLbMIHbeO3jATGzwbCp0S43JdRlteu/+AWc4lUwBR96JLyWglAILxn t+C9SG6DMGdgNiO8FBBe05ZKttZvro7oUoFb17h/8l1qw4R2xxcLNWoc3Rrrk9bn y+8XgUo2d+4otofR96S6Xf97f/vpOhn26G/y8xBGlIn9v64sW8RkGPcnA1I3m0PM MC6SuuQe4THoBu/u0tDv =m/A5 -----END PGP SIGNATURE----- --Sig_/hD8Oq3YrUaNup/ThHb8wffE--