From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 82BFD138A6C for ; Tue, 18 Nov 2014 16:13:28 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 9C6B7E090B; Tue, 18 Nov 2014 16:13:26 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 170EBE0901 for ; Tue, 18 Nov 2014 16:13:26 +0000 (UTC) Received: from big_daddy.dol-sen.ca (S010634bdfa9ecf80.vc.shawcable.net [96.49.31.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id C3186340502 for ; Tue, 18 Nov 2014 16:13:24 +0000 (UTC) Date: Tue, 18 Nov 2014 08:13:15 -0800 From: Brian Dolbec To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH] _slot_operator_update_probe: memoize use_reduce (529660) Message-ID: <20141118081315.261625a1.dolsen@gentoo.org> In-Reply-To: <1416293862-15646-1-git-send-email-zmedico@gentoo.org> References: <1416293862-15646-1-git-send-email-zmedico@gentoo.org> Organization: Gentoo Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: b0d9b972-36df-4824-8ada-af41a62ff29e X-Archives-Hash: 2fb06aaeb5ea7d10384ffc1157019311 On Mon, 17 Nov 2014 22:57:42 -0800 Zac Medico wrote: > Memoize the results of use_reduce calls inside > _slot_operator_update_probe, in order to improve performance. With > memoization, 'emerge -puvDN @world' on one of my computers takes > 22.4% less time, and results in 13.5% fewer use_reduce calls. > > X-Gentoo-Bug: 529660 > X-Gentoo-Url: https://bugs.gentoo.org/show_bug.cgi?id=529660 > --- patch looks good, just did you mean "Memorize" & "memorization" instead of "Memoize" & "memoization" -- Brian Dolbec