From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 685BF1389F5 for ; Mon, 17 Nov 2014 22:47:20 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 73F57E0921; Mon, 17 Nov 2014 22:47:18 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id EF850E08E0 for ; Mon, 17 Nov 2014 22:47:17 +0000 (UTC) Received: from big_daddy.dol-sen.ca (S010634bdfa9ecf80.vc.shawcable.net [96.49.31.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id A9FE73402C3 for ; Mon, 17 Nov 2014 22:47:16 +0000 (UTC) Date: Mon, 17 Nov 2014 14:47:08 -0800 From: Brian Dolbec To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH v2] NewsManager.getUnreadItems: handle EROFS (490732) Message-ID: <20141117144708.1008e0dc.dolsen@gentoo.org> In-Reply-To: <1416026711-21913-1-git-send-email-zmedico@gentoo.org> References: <1415601050-29668-1-git-send-email-zmedico@gentoo.org> <1416026711-21913-1-git-send-email-zmedico@gentoo.org> Organization: Gentoo Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: a76beb93-7810-4360-a9c5-d2fc94ca928f X-Archives-Hash: 8433186936fa832be071fa95036c12f7 On Fri, 14 Nov 2014 20:45:11 -0800 Zac Medico wrote: > When getUnreadItems tries to lock the news.unread file, it's safe to > ignore EROFS. This is handled with a ReadOnlyFileSystem exception > raised from the portage.locks.lockfile function. > > X-Gentoo-Bug: 490732 > X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=490732 > --- > This updated patch fixes the typo spotted by Brian Dolbec. > LGTM, go for it. but for future reference... use brackets to group multiline imports instead of line continuations. - from portage.exception import InvalidLocation, OperationNotPermitted, \ - PermissionDenied + from portage.exception import (InvalidLocation, OperationNotPermitted, + PermissionDenied, ReadOnlyFileSystem) -- Brian Dolbec