From: Brian Dolbec <dolsen@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] [PATCH v2] NewsManager.getUnreadItems: handle EROFS (490732)
Date: Mon, 17 Nov 2014 14:47:08 -0800 [thread overview]
Message-ID: <20141117144708.1008e0dc.dolsen@gentoo.org> (raw)
In-Reply-To: <1416026711-21913-1-git-send-email-zmedico@gentoo.org>
On Fri, 14 Nov 2014 20:45:11 -0800
Zac Medico <zmedico@gentoo.org> wrote:
> When getUnreadItems tries to lock the news.unread file, it's safe to
> ignore EROFS. This is handled with a ReadOnlyFileSystem exception
> raised from the portage.locks.lockfile function.
>
> X-Gentoo-Bug: 490732
> X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=490732
> ---
> This updated patch fixes the typo spotted by Brian Dolbec.
>
LGTM, go for it.
but for future reference...
use brackets to group multiline imports instead of line continuations.
- from portage.exception import InvalidLocation, OperationNotPermitted, \
- PermissionDenied
+ from portage.exception import (InvalidLocation, OperationNotPermitted,
+ PermissionDenied, ReadOnlyFileSystem)
--
Brian Dolbec <dolsen>
prev parent reply other threads:[~2014-11-17 22:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-10 6:30 [gentoo-portage-dev] [PATCH] NewsManager.getUnreadItems: handle EROFS (490732) Zac Medico
2014-11-10 7:51 ` Brian Dolbec
2014-11-10 8:14 ` Zac Medico
2014-11-15 4:45 ` [gentoo-portage-dev] [PATCH v2] " Zac Medico
2014-11-17 22:47 ` Brian Dolbec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141117144708.1008e0dc.dolsen@gentoo.org \
--to=dolsen@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox