Re: [gentoo-portage-dev] [PATCH] NewsManager.getUnreadItems: handle EROFS (490732)

[Brian Dolbec <dolsen@gentoo.org>]

On Sun,  9 Nov 2014 22:30:50 -0800
Zac Medico <zmedico@gentoo.org> wrote:

> When getUnreadItems tries to lock the news.unread file, it's safe to
> ignore EROFS. This is handled with a ReadOnlyFileSystem exception
> raised from the portage.locks.lockfile function.
> 
> X-Gentoo-Bug: 490732
> X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=490732
> ---
>  pym/portage/exception.py | 1 +
>  pym/portage/locks.py     | 7 ++++++-
>  pym/portage/news.py      | 7 ++++---
>  3 files changed, 11 insertions(+), 4 deletions(-)
> 
>...

>  		unread_lock = None
>  		try:
>  			unread_lock = lockfile(unread_filename,
> wantnewlockfile=1)
> -		except (InvalidLocation, OperationNotPermitted,
> PermissionDenied):
> +		except (InvalidLocation, OperationNotPermitted,
> PermissionDenied.
   typo...........^

 :)

> +			ReadOnlyFileSystem):
>  			pass
>  		try:
>  			try:



-- 
Brian Dolbec <dolsen>