[gentoo-portage-dev] [PATCH] LocationsManager: enable user package.bashrc

[gentoo-portage-dev] [PATCH] LocationsManager: enable user package.bashrc

[Zac Medico]

In /etc/portage/profile, we already have support for using directories
in the place of regular config files (portage1_directories = True). So,
go ahead and enable package.bashrc there too.

We could also support /etc/portage/package.bashrc, but that would be
more complicated since /etc/portage/bashrc is the long-standing location
of the user's bashrc which applies to all packages, and package.bashrc
would instead expect /etc/portage/bashrc to be a directory containing
per-package bashrc files. So for now, we only support package.bashrc
inside /etc/portage/profile.
---
 pym/portage/package/ebuild/_config/LocationsManager.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/pym/portage/package/ebuild/_config/LocationsManager.py b/pym/portage/package/ebuild/_config/LocationsManager.py
index 8bf321c..6280a42 100644
--- a/pym/portage/package/ebuild/_config/LocationsManager.py
+++ b/pym/portage/package/ebuild/_config/LocationsManager.py
@@ -132,7 +132,8 @@ class LocationsManager(object):
 				self.user_profile_dir = custom_prof
 				self.profiles.append(custom_prof)
 				self.profiles_complex.append(
-					_profile_node(custom_prof, True, True, ()))
+					_profile_node(custom_prof, True, True,
+					('profile-bashrcs',)))
 			del custom_prof
 
 		self.profiles = tuple(self.profiles)
-- 
2.0.4

Re: [gentoo-portage-dev] [PATCH] LocationsManager: enable user package.bashrc

[Brian Dolbec]

On Fri, 24 Oct 2014 16:22:15 -0700
Zac Medico <zmedico@gentoo.org> wrote:

> In /etc/portage/profile, we already have support for using directories
> in the place of regular config files (portage1_directories = True).
> So, go ahead and enable package.bashrc there too.
> 
> We could also support /etc/portage/package.bashrc, but that would be
> more complicated since /etc/portage/bashrc is the long-standing
> location of the user's bashrc which applies to all packages, and
> package.bashrc would instead expect /etc/portage/bashrc to be a
> directory containing per-package bashrc files. So for now, we only
> support package.bashrc inside /etc/portage/profile.
> ---
>  pym/portage/package/ebuild/_config/LocationsManager.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/pym/portage/package/ebuild/_config/LocationsManager.py
> b/pym/portage/package/ebuild/_config/LocationsManager.py index
> 8bf321c..6280a42 100644 ---
> a/pym/portage/package/ebuild/_config/LocationsManager.py +++
> b/pym/portage/package/ebuild/_config/LocationsManager.py @@ -132,7
> +132,8 @@ class LocationsManager(object): self.user_profile_dir =
> custom_prof self.profiles.append(custom_prof)
>  				self.profiles_complex.append(
> -					_profile_node(custom_prof,
> True, True, ()))
> +					_profile_node(custom_prof,
> True, True,
> +					('profile-bashrcs',)))
>  			del custom_prof
>  
>  		self.profiles = tuple(self.profiles)


I'm a little confused.  Is this a fix for Bertrands bashrc patches
already applied?  Or is it unrelated?
-- 
Brian Dolbec <dolsen>

Re: [gentoo-portage-dev] [PATCH] LocationsManager: enable user package.bashrc

[Zac Medico]

On 11/02/2014 09:19 AM, Brian Dolbec wrote:
> 
> I'm a little confused.  Is this a fix for Bertrands bashrc patches
> already applied?  Or is it unrelated?

It's a feature enhancement to add support for package.bashrc in
/etc/portage/profile. Since /etc/portage/profile is not part of a
repository, there's no associated layout.conf. So, there's no way to
enable the profile-env profile-formats setting in /etc/portage/profile,
except by hardcoding it as shown.
-- 
Thanks,
Zac

Re: [gentoo-portage-dev] [PATCH] LocationsManager: enable user package.bashrc

[Brian Dolbec]

On Sun, 02 Nov 2014 09:27:07 -0800
Zac Medico <zmedico@gentoo.org> wrote:

> On 11/02/2014 09:19 AM, Brian Dolbec wrote:
> > 
> > I'm a little confused.  Is this a fix for Bertrands bashrc patches
> > already applied?  Or is it unrelated?
> 
> It's a feature enhancement to add support for package.bashrc in
> /etc/portage/profile. Since /etc/portage/profile is not part of a
> repository, there's no associated layout.conf. So, there's no way to
> enable the profile-env profile-formats setting
> in /etc/portage/profile, except by hardcoding it as shown.

OK, works for me... merge away.

-- 
Brian Dolbec <dolsen>