From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id AF1891387D3 for ; Sat, 25 Oct 2014 20:26:15 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 2C058E0B5D; Sat, 25 Oct 2014 20:26:15 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id B095CE0B57 for ; Sat, 25 Oct 2014 20:26:14 +0000 (UTC) Received: from pomiot.lan (mgorny-1-pt.tunnel.tserv28.waw1.ipv6.he.net [IPv6:2001:470:70:353::2]) (using SSLv3 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 74B3133FFF7; Sat, 25 Oct 2014 20:26:12 +0000 (UTC) Date: Sat, 25 Oct 2014 22:26:07 +0200 From: =?ISO-8859-2?B?TWljaGGzIEfzcm55?= To: Zac Medico Cc: gentoo-portage-dev@lists.gentoo.org, Michael Palimaka Subject: Re: [gentoo-portage-dev] [PATCH 1/3] bin/misc-functions.sh: Introduce eqalog and eqawarnlog functions. Message-ID: <20141025222607.283943d9@pomiot.lan> In-Reply-To: <544BFFAB.3000608@gentoo.org> References: <1414253761-6310-1-git-send-email-kensington@gentoo.org> <544BFFAB.3000608@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/8VLSEetdXnXfj1qaNJzMnwy"; protocol="application/pgp-signature" X-Archives-Salt: b1c76e11-a2b4-496e-8ae3-ba406dfabc13 X-Archives-Hash: aa23f7842fde2f7076c4649802c4cee8 --Sig_/8VLSEetdXnXfj1qaNJzMnwy Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable Dnia 2014-10-25, o godz. 12:53:15 Zac Medico napisa=B3(a): > On 10/25/2014 09:15 AM, Michael Palimaka wrote: > > +eqalog() { > > + local tag=3D$1 x > > + shift > > + for x in "$@" ; do > > + echo "${tag}" "${x}" >> "${T}"/qa.log > > + done > > +} > > + > > +eqawarnlog() { > > + eqalog "$@" > > + shift > > + for x in "$@" ; do > > + eqawarn " $x" > > + done > > +} > > + >=20 > These functions are internals, so they need to be prefixed with __ like > __eqalog and __eqawarnlog. eqawarnlog shouldn't be internal since we support adding QA checks in repositories. In fact, I am planning to move some Gentoo-specific QA checks out of portage code. --=20 Best regards, Micha=B3 G=F3rny --Sig_/8VLSEetdXnXfj1qaNJzMnwy Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJUTAdfXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2REJCMDdDQzRGMERBRDA2RUEwQUZFNDFC MDdBMUFFQUVGQjQ0NjRFAAoJELB6GurvtEZO5twP/jTr4y768PT9S2Jqh+K3afAX e1VJf1FVDjoWidK4ET8Md+vsb7ZT875GtF6/zvF2YDBVBu+dK+8Hhf1cuc89iqY9 A0lHeRYUFDP9DVWkilA2FDOPF3yAgTjRD45Tg4CW+aQJ6+IXMeaJ+e3ZRq0rpwri B5EJyxviBt2Md/5I38nRxF2T0Lp7OdyktMsyqAzjSKZLLOvX3tadCxGgaKvKwROM KkM8Q7uSltzC682+tKtTwuI1R/1MJivMRqyyVoRQs/Bwh1xcSuM6KlG4nEeS2n1j +727sPWIJRm6DiWpQ+2S8jOAR0XGrD2G2j1tqCpmR9A9YZRg3hpQjgUUJPDHSNcW aEz52T2uO1mboNxJV0WNM4/hdTZcmy8uIYu48WoY8HiKgIGLhd1lZv95VTVarHlg JBA2p8HBhkYn7HpPFzQCdF07nPri23+fry/dPb3y+HrSsHJ54MErTwSDiPlZXOFu Zx/uduT5r5GN8xvQPVh5HRkFt+iwXme7/VoREnZXXQXKnkvDAKbWeXohaQhh+8c6 BSe54QnYQZGpqdMksNr9jsJzm/RFRUj70VJei/o83RE7/EUh5eRiFfUFLdTz/6Ra O9rlzRuOi65Afoo/N1bx6gyhyMCyZbfZPRWRqICTelthyOC4SwdY+B4Ngi1YUxFB fWlv9jOGhxj+IcPko0LE =9NAV -----END PGP SIGNATURE----- --Sig_/8VLSEetdXnXfj1qaNJzMnwy--