From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 44A251387D3 for ; Sat, 25 Oct 2014 20:25:33 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 4847EE0B58; Sat, 25 Oct 2014 20:25:32 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id C6B8CE0B57 for ; Sat, 25 Oct 2014 20:25:31 +0000 (UTC) Received: from pomiot.lan (mgorny-1-pt.tunnel.tserv28.waw1.ipv6.he.net [IPv6:2001:470:70:353::2]) (using SSLv3 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 956553401CA; Sat, 25 Oct 2014 20:25:29 +0000 (UTC) Date: Sat, 25 Oct 2014 22:25:23 +0200 From: =?ISO-8859-2?B?TWljaGGzIEfzcm55?= To: Zac Medico Cc: gentoo-portage-dev@lists.gentoo.org, Michael Palimaka Subject: Re: [gentoo-portage-dev] [PATCH 1/3] bin/misc-functions.sh: Introduce eqalog and eqawarnlog functions. Message-ID: <20141025222523.2676193c@pomiot.lan> In-Reply-To: <544BFD16.8040501@gentoo.org> References: <1414253761-6310-1-git-send-email-kensington@gentoo.org> <544BFD16.8040501@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/O/HlaPr+OVQN9M/.y3nMLQC"; protocol="application/pgp-signature" X-Archives-Salt: 1635b889-e53c-4f6d-ae69-464ddf6411cf X-Archives-Hash: 64a4853335d75cbc6687f7110c921340 --Sig_/O/HlaPr+OVQN9M/.y3nMLQC Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable Dnia 2014-10-25, o godz. 12:42:14 Zac Medico napisa=B3(a): > On 10/25/2014 09:15 AM, Michael Palimaka wrote: > > +eqalog() { > > + local tag=3D$1 x > > + shift > > + for x in "$@" ; do > > + echo "${tag}" "${x}" >> "${T}"/qa.log > > + done > > +} >=20 > Your patches look good to me, except that I think eqalog should escape > any \n characters that might be embedded in the arguments. Why? That sounds like some unsafe fancy feature only one person would use. Embedding newlines in bash is trivial, why make them implicit with a lot of added complexity? --=20 Best regards, Micha=B3 G=F3rny --Sig_/O/HlaPr+OVQN9M/.y3nMLQC Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJUTAc0XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2REJCMDdDQzRGMERBRDA2RUEwQUZFNDFC MDdBMUFFQUVGQjQ0NjRFAAoJELB6GurvtEZOJKUP/19G1kQWhL6Xr5V/xJ10a5sN I27w78Gw8vVCQ2/XZ0jeT2giktbh3e5r4RXFhTEWlxj0QJvLb5DTAeSQSAS6qek2 nrULffJdMQlcbR3pKwiIOJeGZP2OWYSoPhLWpLjwp4FSYyJidiJey3ML+LIp3thc Pxhnbitcfp00WitKzSxXiQ8EZtC3CzY4JrzAH80F87RSXEtlE3BZKYKdeia/zHH4 /uf5eqpQ0ixdtMprnkHXhXzsmyBuFZCt1fwv2uCvqReIwW4LuRRKh/xlDOZOz0rj HW2dkHbs6dM8unlq6m0AN8tkRiuurAf0KES9btBBfk9E3pFJPdYaIRv1Pte6AvLQ QDA2YztJBvgXxhQXw9pPERnFQW3V6ZSXaQwj69fBHk89U+Pl+VqhDc4gORpULZ4D AzK9Sjg+JoLNW8R3RGLyn72wqSK8cHTHtQFqHOqrvR5ZVTZnrNEVi00eEFaMGbsr XYKj04J19g0xhh2Dezpw46ay2eIpWA0tQTjycG70ZX5HQ8XQB8f/g+B7DB63WW2/ KrO6U2F2wg2DpdwUVMposkuQBWk+bFQwLa7KL/2sQ++hr6Jxlv6VyjuBIP/8LD2d wfQe5JY1sv80hfDywqln8dTtKD5xUVonRGSSX1VJaEstHzwyS/3tKzkE9PS0Z9V6 jni9+2XccR9/Nez5nMGS =OxS+ -----END PGP SIGNATURE----- --Sig_/O/HlaPr+OVQN9M/.y3nMLQC--