From: "Michał Górny" <mgorny@gentoo.org>
To: Zac Medico <zmedico@gentoo.org>
Cc: gentoo-portage-dev@lists.gentoo.org,
Michael Palimaka <kensington@gentoo.org>
Subject: Re: [gentoo-portage-dev] [PATCH 1/3] bin/misc-functions.sh: Introduce eqalog and eqawarnlog functions.
Date: Sat, 25 Oct 2014 22:25:23 +0200 [thread overview]
Message-ID: <20141025222523.2676193c@pomiot.lan> (raw)
In-Reply-To: <544BFD16.8040501@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 627 bytes --]
Dnia 2014-10-25, o godz. 12:42:14
Zac Medico <zmedico@gentoo.org> napisał(a):
> On 10/25/2014 09:15 AM, Michael Palimaka wrote:
> > +eqalog() {
> > + local tag=$1 x
> > + shift
> > + for x in "$@" ; do
> > + echo "${tag}" "${x}" >> "${T}"/qa.log
> > + done
> > +}
>
> Your patches look good to me, except that I think eqalog should escape
> any \n characters that might be embedded in the arguments.
Why? That sounds like some unsafe fancy feature only one person would
use. Embedding newlines in bash is trivial, why make them implicit with
a lot of added complexity?
--
Best regards,
Michał Górny
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 949 bytes --]
next prev parent reply other threads:[~2014-10-25 20:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-25 16:15 [gentoo-portage-dev] [PATCH 1/3] bin/misc-functions.sh: Introduce eqalog and eqawarnlog functions Michael Palimaka
2014-10-25 16:16 ` [gentoo-portage-dev] [PATCH 2/3] install-qa-check.d/05double-D: Write to log and improve consistency Michael Palimaka
2014-10-26 15:14 ` Michael Palimaka
2014-10-25 16:16 ` [gentoo-portage-dev] [PATCH 3/3] install-qa-check.d/90world-writable: Write log and general cleanup Michael Palimaka
2014-10-26 15:16 ` Michael Palimaka
2014-10-25 19:42 ` [gentoo-portage-dev] [PATCH 1/3] bin/misc-functions.sh: Introduce eqalog and eqawarnlog functions Zac Medico
2014-10-25 20:25 ` Michał Górny [this message]
2014-10-25 20:28 ` Zac Medico
2014-10-25 20:41 ` Michał Górny
2014-10-25 20:53 ` Zac Medico
2014-10-25 19:53 ` Zac Medico
2014-10-25 19:54 ` Zac Medico
2014-10-25 20:00 ` Zac Medico
2014-10-25 20:13 ` [gentoo-portage-dev] " Michael Palimaka
2014-10-25 20:15 ` Zac Medico
2014-10-25 20:26 ` [gentoo-portage-dev] " Michał Górny
2014-10-25 20:32 ` Zac Medico
2014-10-25 20:57 ` Zac Medico
2014-10-26 19:31 ` [gentoo-portage-dev] " Michael Palimaka
2014-10-26 20:05 ` Zac Medico
2014-10-27 13:15 ` Michael Palimaka
2014-10-27 19:33 ` Zac Medico
2014-10-26 15:12 ` [gentoo-portage-dev] [PATCH 1/3] " Michael Palimaka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141025222523.2676193c@pomiot.lan \
--to=mgorny@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
--cc=kensington@gentoo.org \
--cc=zmedico@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox