From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id B252F13877A for ; Fri, 22 Aug 2014 22:56:22 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 3FCF5E0851; Fri, 22 Aug 2014 22:56:22 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id B38D0E0833 for ; Fri, 22 Aug 2014 22:56:21 +0000 (UTC) Received: from pomiot.lan (77-254-87-255.adsl.inetia.pl [77.254.87.255]) (using SSLv3 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id DB40533FED0; Fri, 22 Aug 2014 22:56:19 +0000 (UTC) Date: Sat, 23 Aug 2014 00:52:53 +0200 From: =?ISO-8859-2?B?TWljaGGzIEfzcm55?= To: Brian Dolbec Cc: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH 4/6] tests: Fix running on installed copy of Portage Message-ID: <20140823005253.3c2812b2@pomiot.lan> In-Reply-To: <20140822151912.62d83ac0.dolsen@gentoo.org> References: <1408652384-1954-1-git-send-email-mgorny@gentoo.org> <1408652384-1954-5-git-send-email-mgorny@gentoo.org> <20140822151912.62d83ac0.dolsen@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.24; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/mZ=7YjK_nGO2antmhM+sbo_"; protocol="application/pgp-signature" X-Archives-Salt: 0c6aca9a-463e-4576-89ad-7cb0d13a65fd X-Archives-Hash: 0483b85578803204bcf99ffd4d9e897b --Sig_/mZ=7YjK_nGO2antmhM+sbo_ Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable Dnia 2014-08-22, o godz. 15:19:12 Brian Dolbec napisa=B3(a): > On Thu, 21 Aug 2014 22:19:42 +0200 > Micha=B3 G=F3rny wrote: >=20 > > --- > > pym/portage/tests/__init__.py | 20 > > ++++++++++++++++++ pym/portage/tests/dbapi/test_portdb_cache.py > > | 5 ++--- pym/portage/tests/emerge/test_emerge_slot_abi.py | 7 > > +++---- pym/portage/tests/emerge/test_simple.py | 26 > > ++++++++++++------------ > > pym/portage/tests/lint/test_compile_modules.py | 10 +++++---- > > pym/portage/tests/lint/test_import_modules.py | 8 ++++++-- > > pym/portage/tests/repoman/test_simple.py | 8 +++++--- > > pym/portage/tests/resolver/ResolverPlayground.py | 8 +++++--- > > pym/portage/tests/util/test_getconfig.py | 5 ++--- 9 files > > changed, 62 insertions(+), 35 deletions(-) > >=20 > =20 > diff --git a/pym/portage/tests/util/test_getconfig.py > > b/pym/portage/tests/util/test_getconfig.py index e5fd60f..16f415c > > 100644 --- a/pym/portage/tests/util/test_getconfig.py > > +++ b/pym/portage/tests/util/test_getconfig.py > > @@ -3,6 +3,7 @@ > > =20 > > import tempfile > > =20 > > +import portage > > from portage import os > > from portage import shutil > > from portage import _unicode_encode > > @@ -26,9 +27,7 @@ class GetConfigTestCase(TestCase): > > } > > =20 > > def testGetConfig(self): > > - > > - make_globals_file =3D os.path.join(PORTAGE_BASE_PATH, > > - 'cnf', 'make.globals') > > + make_globals_file =3D os.path.join(self.cnf_path, > > "make.globals") d =3D getconfig(make_globals_file) > > for k, v in self._cases.items(): > > self.assertEqual(d[k], v) >=20 > Why was "import portage" added but not used anywhere in additional code? Good catch. It was used in the previous version of the patch. Fixed now. --=20 Best regards, Micha=B3 G=F3rny --Sig_/mZ=7YjK_nGO2antmhM+sbo_ Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJT98nLXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2REJCMDdDQzRGMERBRDA2RUEwQUZFNDFC MDdBMUFFQUVGQjQ0NjRFAAoJELB6GurvtEZOTLIP/2MeQxwhpbhxDQ777lJxiMz7 TmHiXzXmfbAmGyLS3c8GxkvHgmYz851Dbq8A0Rfid3v71nw4sAjQBbHtZetv53oW NPrxT6IFG5XX8GK5ofwR2hB8H6Qft3PBJ5DJB2hrOAA2DVlR83XHo4L0+Yt46N+c Yu2lYRar3vA6mxP2aHzLZcXA0BIhz0ixwAq75YSUUhraMDvhJ3UMFVYEB1Nj1MOY pUb4KuEf/zthNSWpO0OPZqv8vj+28C1extGcUQ48Wxkse9w4Ia7rHHmFX/nYA9F2 n0mW4Ua0dexaKeiQ6HuLj65eUU6MobCDetSGw+pOaeD7iDvQaXboUGK5GIveoWGN AfCeE+kyk7/zXix7mnKHlU4bfUeuiB48URsu0H1o5Hn1AhGgGX2oPrlrqvrmdrgS FAcrXaURMDS4EswdFi9Q87+pBmUU9Z3GVdYQmMRNVM+W0fiMdGM1EhVMzTUDGLGp +lmarN3uggxacH3rjVUG1b49qJu7JA4ATjGCkjpsSH+mnY/k6bG86UAhHHrsIhdz v4TA+CRYH+Fpb5k8YyH8gMnvOLkcBc3a1/BsNH4oNoLcPaLjOHlTXtHV8w3n5DG9 7f0hSYsDCiQOu3vrHX8iW7091YT1PLfve8FS48vroXLKdIW0etUmCCGWUEXXhb3j oXuimaQ3bK7OHrN4U3cH =hqUN -----END PGP SIGNATURE----- --Sig_/mZ=7YjK_nGO2antmhM+sbo_--