From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 29A1D13877A for ; Fri, 22 Aug 2014 22:20:27 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 76CFBE07ED; Fri, 22 Aug 2014 22:20:26 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 05BF1E07EC for ; Fri, 22 Aug 2014 22:20:25 +0000 (UTC) Received: from big_daddy.dol-sen.ca (S010600222de111ff.vc.shawcable.net [96.49.5.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id 379C833DF97 for ; Fri, 22 Aug 2014 22:20:25 +0000 (UTC) Date: Fri, 22 Aug 2014 15:19:12 -0700 From: Brian Dolbec To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH 4/6] tests: Fix running on installed copy of Portage Message-ID: <20140822151912.62d83ac0.dolsen@gentoo.org> In-Reply-To: <1408652384-1954-5-git-send-email-mgorny@gentoo.org> References: <1408652384-1954-1-git-send-email-mgorny@gentoo.org> <1408652384-1954-5-git-send-email-mgorny@gentoo.org> Organization: Gentoo Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: 2e5c16aa-347f-4937-9d79-0e44ee56ad3a X-Archives-Hash: 8e109202b80dd436292b948376c46a3a On Thu, 21 Aug 2014 22:19:42 +0200 Micha=C5=82 G=C3=B3rny wrote: > --- > pym/portage/tests/__init__.py | 20 > ++++++++++++++++++ pym/portage/tests/dbapi/test_portdb_cache.py > | 5 ++--- pym/portage/tests/emerge/test_emerge_slot_abi.py | 7 > +++---- pym/portage/tests/emerge/test_simple.py | 26 > ++++++++++++------------ > pym/portage/tests/lint/test_compile_modules.py | 10 +++++---- > pym/portage/tests/lint/test_import_modules.py | 8 ++++++-- > pym/portage/tests/repoman/test_simple.py | 8 +++++--- > pym/portage/tests/resolver/ResolverPlayground.py | 8 +++++--- > pym/portage/tests/util/test_getconfig.py | 5 ++--- 9 files > changed, 62 insertions(+), 35 deletions(-) >=20 =20 diff --git a/pym/portage/tests/util/test_getconfig.py > b/pym/portage/tests/util/test_getconfig.py index e5fd60f..16f415c > 100644 --- a/pym/portage/tests/util/test_getconfig.py > +++ b/pym/portage/tests/util/test_getconfig.py > @@ -3,6 +3,7 @@ > =20 > import tempfile > =20 > +import portage > from portage import os > from portage import shutil > from portage import _unicode_encode > @@ -26,9 +27,7 @@ class GetConfigTestCase(TestCase): > } > =20 > def testGetConfig(self): > - > - make_globals_file =3D os.path.join(PORTAGE_BASE_PATH, > - 'cnf', 'make.globals') > + make_globals_file =3D os.path.join(self.cnf_path, > "make.globals") d =3D getconfig(make_globals_file) > for k, v in self._cases.items(): > self.assertEqual(d[k], v) Why was "import portage" added but not used anywhere in additional code? --=20 Brian Dolbec