From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 82FAD13877A for ; Wed, 6 Aug 2014 21:08:46 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id DDC23E0921; Wed, 6 Aug 2014 21:08:43 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 52013E0833 for ; Wed, 6 Aug 2014 21:08:43 +0000 (UTC) Received: from big_daddy.dol-sen.ca (S010600222de111ff.vc.shawcable.net [96.49.5.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id 368FF340019 for ; Wed, 6 Aug 2014 21:08:42 +0000 (UTC) Date: Wed, 6 Aug 2014 14:07:42 -0700 From: Brian Dolbec To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH] repoman: fix atom.blocker checks. Message-ID: <20140806140742.0455deaa.dolsen@gentoo.org> In-Reply-To: <20140804235100.2ac7e080@pomiot.lan> References: <1407142947-7067-1-git-send-email-mgorny@gentoo.org> <20140804235100.2ac7e080@pomiot.lan> Organization: Gentoo Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/F0GVxl27MZvlsFP6eJDMl7O"; protocol="application/pgp-signature" X-Archives-Salt: 27b892cc-1174-4d3b-843b-14435b7a80fa X-Archives-Hash: 79a0af90203261aa92675a8e9df0ed1a --Sig_/F0GVxl27MZvlsFP6eJDMl7O Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, 4 Aug 2014 23:51:00 +0200 Micha=C5=82 G=C3=B3rny wrote: > Dnia 2014-08-04, o godz. 11:02:27 > Micha=C5=82 G=C3=B3rny napisa=C5=82(a): >=20 > > The original checks assume that no-blocker is denoted as 'None'. > > However, currently atom.blocker returns just 'False'. >=20 > So, applying this patch restores the 'dependency.unknown' check that > wasn't working for some time. As a result, I think it slows down > repoman near GNOME & KDE categories (though no real measurements), > and gives 4779 new warnings. >=20 > Some of those warnings concern only || () dependencies, e.g.: >=20 > x11-wm/awesome/awesome-3.5.5.ebuild: DEPEND: > =20 > which applies to: >=20 > || ( =3Dx11-libs/libX11-1.3.99.901 ) >=20 > in the ebuild. >=20 > However, some look like false positives and need further > investigation: >=20 > app-emulation/emul-linux-x86-baselibs/emul-linux-x86-baselibs-20140406-r4= .ebuild: > RDEPEND: >=3Dapp-arch/bzip2-1.0.6-r4[abi_x86_32(-)], > >=3Dapp-arch/xz-utils-5.0.5-r1[abi_x86_32(-)], > >>=3Dapp-text/libpaper-1.1.24-r2[abi_x86_32(-)], > >>>=3Ddev-db/sqlite-3.8.3:3[abi_x86_32(-)], > >>>>=3Ddev-libs/dbus-glib-0.100.2-r1[abi_x86_32(-)], > >>>>>=3Ddev-libs/elfutils-0.155-r1[abi_x86_32(-)], > >>>>>>=3Ddev-libs/expat-2.1.0-r3[abi_x86_32(-)], > >>>>>>>=3Ddev-libs/glib-2.34.3:2[abi_x86_32(-)], > >>>>>>>>=3Ddev-libs/gmp-5.1.3-r1[abi_x86_32(-)], > >>>>>>>>>=3Ddev-libs/json-c-0.11-r1[abi_x86_32(-)], > >>>>>>>>>>=3Ddev-libs/libelf-0.8.13-r2[abi_x86_32(-)], > >>>>>>>>>>>=3Ddev-libs/libgcrypt-1.5.3-r100:11[abi_x86_32(-)], > >>>>>>>>>>>>=3Ddev-libs/libgcrypt-1.6.1-r1:0[abi_x86_32(-)], > >>>>>>>>>>>>>=3Ddev-libs/libgpg-error-1.12-r1[abi_x86_32(-)], > >>>>>>>>>>>>>>=3Ddev-libs/libpcre-8.33-r1[abi_x86_32(-)], > >>>>>>>>>>>>>>>=3Ddev-libs/libtasn1-3.4-r1[abi_x86_32(-)], > >>>>>>>>>>>>>>>>=3Ddev-libs/libxml2-2.9.1-r4[abi_x86_32(-)], > >>>>>>>>>>>>>>>>>=3Ddev-libs/libxslt-1.1.28-r2[abi_x86_32(-)], > >>>>>>>>>>>>>>>>>>=3Ddev-libs/lzo-2.06-r1[abi_x86_32(-)], > >>>>>>>>>>>>>>>>>>>=3Ddev-libs/nettle-2.7.1-r1[abi_x86_32(-)], > >>>>>>>>>>>>>>>>>>>>=3Ddev-libs/openssl-1.0.1h-r2[abi_x86_32(-)], > >>>>>>>>>>>>>>>>>>>>>=3Ddev-libs/udis86-1.7-r2[abi_x86_32(-)], > >>>>>>>>>>>>>>>>>>>>>>=3Dmedia-libs/giflib-4.2.3-r1[abi_x86_32(-)], > >>>>>>>>>>>>>>>>>>>>>>>=3Dmedia-libs/lcms-2.5-r1:2[abi_x86_32(-)], > >>>>>>>>>>>>>>>>>>>>>>>>=3Dmedia-libs/libpng-1.2.51:1.2[abi_x86_32(-)], > >>>>>>>>>>>>>>>>>>>>>>>>>=3Dmedia-libs/libpng-1.6.10:0[abi_x86_32(-)], > >>>>>>>>>>>>>>>>>>>>>>>>>>=3Dmedia-libs/tiff-3.9.7-r1:3[abi_x86_32(-)], > >>>>>>>>>>>>>>>>>>>>>>>>>>>=3Dmedia-libs/tiff-4.0.3-r6:0[abi_x86_32(-)], > >>>>>>>>>>>>>>>>>>>>>>>>>>>>=3Dsys-apps/acl-2.2.52-r1[abi_x86_32(-)], > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>=3Dsys-apps/attr-2.4.47-r1[abi_x86_32(-)], > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=3Dsys-apps/dbus-1.6.18-r1[abi_x86_32(-)], > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=3Dsys-apps/file-5.18-r1[abi_x86_32(-)], > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=3Dsys-apps/tcp-wrappers-7.6.22-r1[abi_x8= 6_32(-)], > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=3Dsys-apps/util-linux-2.24.1-r3[abi_x86= _32(-)], > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=3Dsys-devel/gettext-0.18.3.2[abi_x86_3= 2(-)], > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=3Dsys-devel/libtool-2.4.2-r1[abi_x86_= 32(-)], > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=3Dsys-devel/llvm-3.3-r3[abi_x86_32(-= )], > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=3Dsys-libs/e2fsprogs-libs-1.42.9[ab= i_x86_32(-)], > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=3Dsys-libs/gdbm-1.10-r1[abi_x86_32= (-)], > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=3Dsys-libs/gpm-1.20.7-r2[abi_x86_= 32(-)], > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=3Dsys-libs/libavc1394-0.5.4-r1[a= bi_x86_32(-)], > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=3Dsys-libs/libraw1394-2.1.0-r1[= abi_x86_32(-)], > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=3Dsys-libs/ncurses-5.9-r3[abi_= x86_32(-)], > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=3Dsys-libs/readline-6.2_p5-r1= :0[abi_x86_32(-)], > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=3Dsys-libs/slang-2.2.4-r1[ab= i_x86_32(-)], > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=3Dsys-libs/zlib-1.2.8-r1[ab= i_x86_32(-)] >=20 > CC-ing multilib@ for consultation :). >=20 > I don't think this should prevent us from committing the patch, > however. If we believe the potential false positives are important > enough, we should just add explanatory 'if False' instead of keeping > a code bug ;). >=20 Since, TomWij isn't around atm. =20 ack to commit this patch. --=20 Brian Dolbec --Sig_/F0GVxl27MZvlsFP6eJDMl7O Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQF8BAEBCgBmBQJT4pkfXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ4Njg4RkQxQ0M3MUMxQzA0RUFFQTQyMzcy MjE0RDkwQTAxNEYxN0NCAAoJECIU2QoBTxfL4IgIAKfnRRMt305Ne/7/Yij0poi2 RsMs8b2yDhLKhyYJ+afKYHJ7oJ20puGaLYj+47RHZcvRO+WX3VhsKF8IevrVsS8E CyrwYe+H3aviS0NJ4HhgA3edW83YkvslfsUsNqOob+p0uanc6EfgtkAqFcPmRxqF eI6P0khOjy0SlORvxtH+IRGRYvF0BJ983BhDVL/V+DTSTDq0AaSr5hhp+6QSgcsI vwJ+GBlAyDmlqvpeFtMUF8UYJ1+YZW7wzaNOjwZXNtpkucCYKwBg91XBChUtEkRZ FyiB2Wv/ARZN9eszFYnPbAUHlTy7eZI1HuqbHwk0wrSvApei5smgBmKA2o85Jl4= =TAm/ -----END PGP SIGNATURE----- --Sig_/F0GVxl27MZvlsFP6eJDMl7O--