From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <gentoo-portage-dev+bounces-3677-garchives=archives.gentoo.org@lists.gentoo.org> Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 373AA13877A for <garchives@archives.gentoo.org>; Mon, 4 Aug 2014 21:50:46 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 6BE24E08B1; Mon, 4 Aug 2014 21:50:41 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id CB039E08AC for <gentoo-portage-dev@lists.gentoo.org>; Mon, 4 Aug 2014 21:50:40 +0000 (UTC) Received: from pomiot.lan (77-255-25-239.adsl.inetia.pl [77.255.25.239]) (using SSLv3 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id D528A33F5A9; Mon, 4 Aug 2014 21:50:36 +0000 (UTC) Date: Mon, 4 Aug 2014 23:51:00 +0200 From: =?ISO-8859-2?B?TWljaGGzIEfzcm55?= <mgorny@gentoo.org> To: gentoo-portage-dev@lists.gentoo.org Cc: multilib@gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH] repoman: fix atom.blocker checks. Message-ID: <20140804235100.2ac7e080@pomiot.lan> In-Reply-To: <1407142947-7067-1-git-send-email-mgorny@gentoo.org> References: <1407142947-7067-1-git-send-email-mgorny@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.24; x86_64-pc-linux-gnu) Precedence: bulk List-Post: <mailto:gentoo-portage-dev@lists.gentoo.org> List-Help: <mailto:gentoo-portage-dev+help@lists.gentoo.org> List-Unsubscribe: <mailto:gentoo-portage-dev+unsubscribe@lists.gentoo.org> List-Subscribe: <mailto:gentoo-portage-dev+subscribe@lists.gentoo.org> List-Id: Gentoo Linux mail <gentoo-portage-dev.gentoo.org> X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/jATJA3tbg3Pe9VPbRv7k2G6"; protocol="application/pgp-signature" X-Archives-Salt: be5bbf9a-21f1-4ab6-a3c8-2be11196072a X-Archives-Hash: c350b0591f634754882aab7d936d7989 --Sig_/jATJA3tbg3Pe9VPbRv7k2G6 Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable Dnia 2014-08-04, o godz. 11:02:27 Micha=B3 G=F3rny <mgorny@gentoo.org> napisa=B3(a): > The original checks assume that no-blocker is denoted as 'None'. > However, currently atom.blocker returns just 'False'. So, applying this patch restores the 'dependency.unknown' check that wasn't working for some time. As a result, I think it slows down repoman near GNOME & KDE categories (though no real measurements), and gives 4779 new warnings. Some of those warnings concern only || () dependencies, e.g.: x11-wm/awesome/awesome-3.5.5.ebuild: DEPEND: <x11-libs/libX11-1.3.99.901[xcb] which applies to: || ( <x11-libs/libX11-1.3.99.901[xcb] >=3Dx11-libs/libX11-1.3.99.901 ) in the ebuild. However, some look like false positives and need further investigation: app-emulation/emul-linux-x86-baselibs/emul-linux-x86-baselibs-20140406-r4.e= build: RDEPEND: >=3Dapp-arch/bzip2-1.0.6-r4[abi_x86_32(-)], >=3Dapp-arch/xz= -utils-5.0.5-r1[abi_x86_32(-)], >=3Dapp-text/libpaper-1.1.24-r2[abi_x86_32(= -)], >=3Ddev-db/sqlite-3.8.3:3[abi_x86_32(-)], >=3Ddev-libs/dbus-glib-0.100= .2-r1[abi_x86_32(-)], >=3Ddev-libs/elfutils-0.155-r1[abi_x86_32(-)], >=3Dde= v-libs/expat-2.1.0-r3[abi_x86_32(-)], >=3Ddev-libs/glib-2.34.3:2[abi_x86_32= (-)], >=3Ddev-libs/gmp-5.1.3-r1[abi_x86_32(-)], >=3Ddev-libs/json-c-0.11-r1= [abi_x86_32(-)], >=3Ddev-libs/libelf-0.8.13-r2[abi_x86_32(-)], >=3Ddev-libs= /libgcrypt-1.5.3-r100:11[abi_x86_32(-)], >=3Ddev-libs/libgcrypt-1.6.1-r1:0[= abi_x86_32(-)], >=3Ddev-libs/libgpg-error-1.12-r1[abi_x86_32(-)], >=3Ddev-l= ibs/libpcre-8.33-r1[abi_x86_32(-)], >=3Ddev-libs/libtasn1-3.4-r1[abi_x86_32= (-)], >=3Ddev-libs/libxml2-2.9.1-r4[abi_x86_32(-)], >=3Ddev-libs/libxslt-1.= 1.28-r2[abi_x86_32(-)], >=3Ddev-libs/lzo-2.06-r1[abi_x86_32(-)], >=3Ddev-li= bs/nettle-2.7.1-r1[abi_x86_32(-)], >=3Ddev-libs/openssl-1.0.1h-r2[abi_x86_3= 2(-)], >=3Ddev-libs/udis86-1.7-r2[abi_x86_32(-)], >=3Dmedia-libs/giflib-4.2= .3-r1[abi_x86_32(-)], >=3Dmedia-libs/lcms-2.5-r1:2[abi_x86_32(-)], >=3Dmedi= a-libs/libpng-1.2.51:1.2[abi_x86_32(-)], >=3Dmedia-libs/libpng-1.6.10:0[abi= _x86_32(-)], >=3Dmedia-libs/tiff-3.9.7-r1:3[abi_x86_32(-)], >=3Dmedia-libs/= tiff-4.0.3-r6:0[abi_x86_32(-)], >=3Dsys-apps/acl-2.2.52-r1[abi_x86_32(-)], = >=3Dsys-apps/attr-2.4.47-r1[abi_x86_32(-)], >=3Dsys-apps/dbus-1.6.18-r1[abi= _x86_32(-)], >=3Dsys-apps/file-5.18-r1[abi_x86_32(-)], >=3Dsys-apps/tcp-wra= ppers-7.6.22-r1[abi_x86_32(-)], >=3Dsys-apps/util-linux-2.24.1-r3[abi_x86_3= 2(-)], >=3Dsys-devel/gettext-0.18.3.2[abi_x86_32(-)], >=3Dsys-devel/libtool= -2.4.2-r1[abi_x86_32(-)], >=3Dsys-devel/llvm-3.3-r3[abi_x86_32(-)], >=3Dsys= -libs/e2fsprogs-libs-1.42.9[abi_x86_32(-)], >=3Dsys-libs/gdbm-1.10-r1[abi_x= 86_32(-)], >=3Dsys-libs/gpm-1.20.7-r2[abi_x86_32(-)], >=3Dsys-libs/libavc13= 94-0.5.4-r1[abi_x86_32(-)], >=3Dsys-libs/libraw1394-2.1.0-r1[abi_x86_32(-)]= , >=3Dsys-libs/ncurses-5.9-r3[abi_x86_32(-)], >=3Dsys-libs/readline-6.2_p5-= r1:0[abi_x86_32(-)], >=3Dsys-libs/slang-2.2.4-r1[abi_x86_32(-)], >=3Dsys-li= bs/zlib-1.2.8-r1[abi_x86_32(-)] CC-ing multilib@ for consultation :). I don't think this should prevent us from committing the patch, however. If we believe the potential false positives are important enough, we should just add explanatory 'if False' instead of keeping a code bug ;). --=20 Best regards, Micha=B3 G=F3rny --Sig_/jATJA3tbg3Pe9VPbRv7k2G6 Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJT4ABEXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2REJCMDdDQzRGMERBRDA2RUEwQUZFNDFC MDdBMUFFQUVGQjQ0NjRFAAoJELB6GurvtEZOceAP+wSZ9IadQS1ryeiY+0vUjYjo 6Em3skhMUMT2KDjr62i36duv4pN+d36+sjGXbxR6sGuFvlOXEioELpouyc3dIG14 XCgBEWlWkqIGJdSvX7/3wti0bDtqoSTslwQzJ3FQ849cOs0Vyb8dOx9pyDrpq8Ii oeW/6yacdWDVgYIaRfPRLZr3aoqrqP4Ozs8KfO2u2r2UTXWE7w9O9bjin5W6TAnR yxvxyPt4VtjkMJIgjL8fpDGK0fyeSkEaJCs1QcHJvsoRjvBK1ivxysEY2i4+iPiT O/vCWDwsGJ6p/hIF2BAlSy7hpO5+DGMbeun/LI0o/2dcGTi/fwWxhKOSCmRaxWui tJuoZ+HghLoS7giIy5aLCNeyqKnqeWECPGOegwucQkXh3LKO6qLvr8/nCOyM+4tf fECr+H9YMwx0n+5I2YpmTubJ9Ri6s4eF7ntcyV/hZkXvkp7IUc6ZrQf1cD+Kxrlf xzeZRs5sSP87GUcK6hpDgIbnVd4iKNE82BFoIzPN5ChpAlQ38O4Z/pOMNsYewi/k 63rvniMV9Pe6gnHEtvVNNH3GAysqziUnMDm39zzlj/CHAQHfjEiiK/Ch1e4WjB6T 40Cf9cI4tUeB9V/6CKp7BkFSvIcfIwPylDU74tjb6ghrvemej5jnmI1zNRRT1hVH vrnzlr2xCD6ak2KiTEQh =P+dN -----END PGP SIGNATURE----- --Sig_/jATJA3tbg3Pe9VPbRv7k2G6--